From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock
Date: Wed, 25 Mar 2026 15:07:40 +0100 [thread overview]
Message-ID: <ded77d4e-7ec3-4f3c-863c-2c0ef490e494@kernel.org> (raw)
In-Reply-To: <20260325135811.148480-3-jonathanh@nvidia.com>
On 25/03/2026 14:58, Jon Hunter wrote:
> The PTP clock for the Tegra234 MGBE device is incorrectly named
> 'ptp-ref' and should be 'ptp_ref'. This is causing the following
> warning to be observed on Tegra234 platforms that use this device:
>
> ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate
> WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed
>
> Although this constitutes an ABI breakage in the binding for this
> device, PTP support has clearly never worked and so fix this now
> so we can correct the device-tree for this device. Note that the
I don't understand that explanation.
Driver dwmac-tegra.c: ptp-ref
Binding: ptp-ref
DTS: ptp-ref
but you say that nothing was working correctly?
Judging by these three - driver+binding+dts - obvious fix is no fix
because everything was fine, so please clarify the exact problem.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-25 14:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 13:58 [PATCH V3 0/3] net: stmmac: Fix Tegra234 MGBE clock Jon Hunter
2026-03-25 13:58 ` [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234 Jon Hunter
2026-03-26 8:32 ` Krzysztof Kozlowski
2026-03-25 13:58 ` [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock Jon Hunter
2026-03-25 14:07 ` Krzysztof Kozlowski [this message]
2026-03-25 14:09 ` Krzysztof Kozlowski
2026-03-25 14:26 ` Jon Hunter
2026-03-26 8:30 ` Krzysztof Kozlowski
2026-03-25 13:58 ` [PATCH V3 3/3] arm64: tegra: " Jon Hunter
2026-03-26 8:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded77d4e-7ec3-4f3c-863c-2c0ef490e494@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox