From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
"biju.das.au" <biju.das.au@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ovidiu Panait <ovidiu.panait.rb@renesas.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: call phy_init_hw() in phy resume path
Date: Sat, 11 Apr 2026 15:50:13 +0200 [thread overview]
Message-ID: <dedab35c-39f4-469b-9227-cb8925d83b8e@lunn.ch> (raw)
In-Reply-To: <admMethCSjOQhu8g@shell.armlinux.org.uk>
> So, I question whether any of the functions in this driver actually
> have a valid reason to take phydev->lock - looks to me like a not
> very well written driver.
>
> In cases like this, I don't think we should make things more
> difficult in the core just because we have a lockdep splat when that
> can be avoided by killing off unnecessary locking.
Agreed. This patchset should cleanup these locks.
We also need to look at lan937x_dsp_workaround(). I also don't see
what that mutex lock/unlock is protecting. Accessing bank registers
need to be protected, so doing one additional access within that
should not need additional protection.
Andrew
next prev parent reply other threads:[~2026-04-11 13:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 14:29 [PATCH net-next] net: phy: call phy_init_hw() in phy resume path Biju
2026-04-10 14:51 ` Russell King (Oracle)
2026-04-10 14:55 ` Russell King (Oracle)
2026-04-10 17:27 ` Biju Das
2026-04-10 23:51 ` Russell King (Oracle)
2026-04-10 15:15 ` Andrew Lunn
2026-04-10 15:22 ` Russell King (Oracle)
2026-04-10 15:38 ` Biju Das
2026-04-10 16:00 ` Andrew Lunn
2026-04-10 16:41 ` Biju Das
2026-04-10 23:49 ` Russell King (Oracle)
2026-04-11 13:50 ` Andrew Lunn [this message]
2026-04-11 14:32 ` Biju Das
2026-04-11 16:46 ` Russell King (Oracle)
2026-04-10 17:00 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dedab35c-39f4-469b-9227-cb8925d83b8e@lunn.ch \
--to=andrew@lunn.ch \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox