From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, mac@mcrowe.com
Subject: Re: [PATCH net] r8169: disable default rx interrupt coalescing on RTL8168
Date: Sat, 30 Mar 2019 19:41:34 +0100 [thread overview]
Message-ID: <dedcb597-2e78-26c1-028e-fbf02bb3c0c4@gmail.com> (raw)
In-Reply-To: <20190330.110617.1344047860723685932.davem@davemloft.net>
On 30.03.2019 19:06, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Sat, 30 Mar 2019 17:13:24 +0100
>
>> It was reported that re-introducing ASPM, in combination with RX
>> interrupt coalescing, results in significantly increased packet
>> latency, see [0]. Disabling ASPM or RX interrupt coalescing fixes
>> the issue. Therefore change the driver's default to disable RX
>> interrupt coalescing. Users still have the option to enable RX
>> coalescing via ethtool.
>>
>> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496
>>
>> Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support")
>> Reported-by: Mike Crowe <mac@mcrowe.com>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Applied and queued up for -stable.
>
> Frankly, I think we were better off with ASPM disabled. But I know
> a lot of people find that unacceptable.
>
Yes, I can hear the notebook owners scream already, and complain about
reduced battery runtime. It would help to have an opt-in option for
ASPM. But a module parameter for it is discouraged, and I see no other
acceptable way to control ASPM on the chip side. I could misuse some
ethtool callback or add a new tunable. But controlling a PCI feature
through ethtool doesn't sound too nice. Maybe I could add a sysfs
attribute.
> This chip has some many quirks/warts when ASPM is enabled, look how
> long it took us to A) get ASPM enabled reasonably and B) discover
> this bug.
>
next prev parent reply other threads:[~2019-03-30 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 16:13 [PATCH net] r8169: disable default rx interrupt coalescing on RTL8168 Heiner Kallweit
2019-03-30 18:06 ` David Miller
2019-03-30 18:41 ` Heiner Kallweit [this message]
2019-04-01 8:50 ` Mike Crowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dedcb597-2e78-26c1-028e-fbf02bb3c0c4@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=mac@mcrowe.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).