From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632ACC43381 for ; Sat, 30 Mar 2019 18:41:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30F68218A3 for ; Sat, 30 Mar 2019 18:41:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ogrFxPsl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730698AbfC3Sln (ORCPT ); Sat, 30 Mar 2019 14:41:43 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37489 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730606AbfC3Sln (ORCPT ); Sat, 30 Mar 2019 14:41:43 -0400 Received: by mail-wr1-f65.google.com with SMTP id w10so6605450wrm.4 for ; Sat, 30 Mar 2019 11:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3I+Gqh1OBMuZmNhz2r+AZk4L4DexMS7F49KnG7Ml6Pk=; b=ogrFxPsl8gUIz7ai/vQFIDrFty5021NWPgrj10bcnSSWjFuJuOUpdcYEaiS5ZsfZQ4 1O7CQtwjqQnkTRQvTd6x77Gehrq7JuiN+6xl7yuY7m7JrMizFuNejbJWpIFDWseg8MbU ZeBIpplSZ9cuw/74U4qFLVoHAKMdhuxefnRcrGVf3nPKUKk4Wu/BudtQnmhO1n//YHq5 FNlLvppCnxyGAAkkxNUAag8hRC0dGWRE4Ju+nivXKxbnl7pWyF4Ci0n0sMbTU4H6Llo2 W5I5qz7V9upt17gFK3wH4my5okmDPFndexQdBcV7PFYaBvZ3BKEtocmgHb1uI2ln4tE3 4L0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3I+Gqh1OBMuZmNhz2r+AZk4L4DexMS7F49KnG7Ml6Pk=; b=fFjxquFpLCxnE78H4hIgpSFpeBFu/hPpPrkKypUvJupFJINEtOzAbUzc1G9zgz8X4z 3vinBSqv89knHKGJjRkXJvXdydd5o3WJTsPcsvmTfifD8uheIH7MWW9Ibs9EBxVOldKt 7oCsyO1eT7okWchOp24bxghxZAJj1bwE8YOF7eQY5CZEmNLxOfB3YAs2Lx9/fyNtqDtd um+zOJyBW9tb9rtNckkgTZBJB8FNwKKPCxYMkM3UALKMfZV2XNPX0VGLVJgGfbfHbCpv oe7lWkpyD2JutaE9HzBkoebVxJ6Ip+YJyUxyBZEmIFx01i49IdLVarmtj3SOvFicYgrU qzzA== X-Gm-Message-State: APjAAAULxkMxA27aiPv5KOwhbPay8u8xG/xArcQeF9z/hyBYbVM9JehF C4ozQvQ8YtE88GxS6ZBstoE= X-Google-Smtp-Source: APXvYqxVjZKxFvnLfTIUIUeEjOYNlvalyxSvF5DCLzhmgPnIgvBLYKlN5/IsjRWxkjm/u0bLxHDiQw== X-Received: by 2002:adf:ee0e:: with SMTP id y14mr18182261wrn.21.1553971301817; Sat, 30 Mar 2019 11:41:41 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:7ccd:5549:2050:93de? (p200300EA8BE1DD007CCD5549205093DE.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:7ccd:5549:2050:93de]) by smtp.googlemail.com with ESMTPSA id v16sm9928584wro.48.2019.03.30.11.41.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Mar 2019 11:41:40 -0700 (PDT) Subject: Re: [PATCH net] r8169: disable default rx interrupt coalescing on RTL8168 To: David Miller Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, mac@mcrowe.com References: <20190330.110617.1344047860723685932.davem@davemloft.net> From: Heiner Kallweit Message-ID: Date: Sat, 30 Mar 2019 19:41:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190330.110617.1344047860723685932.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 30.03.2019 19:06, David Miller wrote: > From: Heiner Kallweit > Date: Sat, 30 Mar 2019 17:13:24 +0100 > >> It was reported that re-introducing ASPM, in combination with RX >> interrupt coalescing, results in significantly increased packet >> latency, see [0]. Disabling ASPM or RX interrupt coalescing fixes >> the issue. Therefore change the driver's default to disable RX >> interrupt coalescing. Users still have the option to enable RX >> coalescing via ethtool. >> >> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496 >> >> Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support") >> Reported-by: Mike Crowe >> Signed-off-by: Heiner Kallweit > > Applied and queued up for -stable. > > Frankly, I think we were better off with ASPM disabled. But I know > a lot of people find that unacceptable. > Yes, I can hear the notebook owners scream already, and complain about reduced battery runtime. It would help to have an opt-in option for ASPM. But a module parameter for it is discouraged, and I see no other acceptable way to control ASPM on the chip side. I could misuse some ethtool callback or add a new tunable. But controlling a PCI feature through ethtool doesn't sound too nice. Maybe I could add a sysfs attribute. > This chip has some many quirks/warts when ASPM is enabled, look how > long it took us to A) get ASPM enabled reasonably and B) discover > this bug. >