From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yunsheng Lin Subject: Re: [PATCH] net: fix the per task frag allocator size Date: Fri, 23 Nov 2018 10:19:23 +0800 Message-ID: References: <1542938606-9676-1-git-send-email-lirongqing@baidu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Li RongQing , , Return-path: Received: from szxga07-in.huawei.com ([45.249.212.35]:33456 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727343AbeKWNBm (ORCPT ); Fri, 23 Nov 2018 08:01:42 -0500 In-Reply-To: <1542938606-9676-1-git-send-email-lirongqing@baidu.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/11/23 10:03, Li RongQing wrote: > when fill task frag, 32K pages, 128MB memory is asked, it > hardly successes when system has memory stress > > and commit '5640f7685831 ("net: use a per task frag allocator")' > said it wants 32768 bytes, not 32768 pages: > > "(up to 32768 bytes per frag, thats order-3 pages on x86)" > > Fixes: 5640f7685831e ("net: use a per task frag allocator") > Signed-off-by: Zhang Yu > Signed-off-by: Li RongQing > --- > net/core/sock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/core/sock.c b/net/core/sock.c > index 6d7e189e3cd9..e3cbefeedf5c 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -2186,8 +2186,8 @@ static void sk_leave_memory_pressure(struct sock *sk) > } > } > > -/* On 32bit arches, an skb frag is limited to 2^15 */ > -#define SKB_FRAG_PAGE_ORDER get_order(32768) > +/* On 32bit arches, an skb frag is limited to 2^15 bytes*/ > +#define SKB_FRAG_PAGE_ORDER get_order(8) get_order(8) returns zero here if I understood it correctly. > > /** > * skb_page_frag_refill - check that a page_frag contains enough room >