From: "Tantilov, Emil S" <emil.s.tantilov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <intel-wired-lan@lists.osuosl.org>, <shannon.nelson@amd.com>,
<simon.horman@corigine.com>, <leon@kernel.org>,
<decot@google.com>, <willemb@google.com>,
Alan Brady <alan.brady@intel.com>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, Alice Michael <alice.michael@intel.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
Phani Burra <phani.r.burra@intel.com>,
"Pavan Kumar Linga" <pavan.kumar.linga@intel.com>
Subject: Re: [PATCH iwl-next v5 08/15] idpf: configure resources for RX queues
Date: Mon, 15 May 2023 19:53:40 -0700 [thread overview]
Message-ID: <def61d08-c340-fcf2-d82c-a0d036bade4f@intel.com> (raw)
In-Reply-To: <20230513184714.4e0b9315@hermes.local>
On 5/13/2023 6:47 PM, Stephen Hemminger wrote:
> On Sat, 13 May 2023 15:57:03 -0700
> Emil Tantilov <emil.s.tantilov@intel.com> wrote:
>
>> +/**
>> + * idpf_is_feature_ena - Determine if a particular feature is enabled
>> + * @vport: vport to check
>> + * @feature: netdev flag to check
>> + *
>> + * Returns true or false if a particular feature is enabled.
>> + */
>> +static inline bool idpf_is_feature_ena(struct idpf_vport *vport,
>> + netdev_features_t feature)
>> +{
>> + return vport->netdev->features & feature;
>> +}
>
> Minor nit. You could make vport const here?
Will do.
Thanks,
Emil
next prev parent reply other threads:[~2023-05-16 2:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 22:56 [PATCH iwl-next v5 00/15] Introduce Intel IDPF driver Emil Tantilov
2023-05-13 22:56 ` [PATCH iwl-next v5 01/15] virtchnl: add virtchnl version 2 ops Emil Tantilov
2023-05-13 22:56 ` [PATCH iwl-next v5 02/15] idpf: add module register and probe functionality Emil Tantilov
2023-05-14 1:45 ` Stephen Hemminger
2023-05-16 2:53 ` Tantilov, Emil S
2023-05-13 22:56 ` [PATCH iwl-next v5 03/15] idpf: add controlq init and reset checks Emil Tantilov
2023-05-13 22:56 ` [PATCH iwl-next v5 04/15] idpf: add core init and interrupt request Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 05/15] idpf: add create vport and netdev configuration Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 06/15] idpf: continue expanding init task Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 07/15] idpf: configure resources for TX queues Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 08/15] idpf: configure resources for RX queues Emil Tantilov
2023-05-14 1:47 ` Stephen Hemminger
2023-05-16 2:53 ` Tantilov, Emil S [this message]
2023-05-13 22:57 ` [PATCH iwl-next v5 09/15] idpf: initialize interrupts and enable vport Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 10/15] idpf: add splitq start_xmit Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 11/15] idpf: add TX splitq napi poll support Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 12/15] idpf: add RX " Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 13/15] idpf: add singleq start_xmit and napi poll Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 14/15] idpf: add ethtool callbacks Emil Tantilov
2023-05-13 22:57 ` [PATCH iwl-next v5 15/15] idpf: configure SRIOV and add other ndo_ops Emil Tantilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def61d08-c340-fcf2-d82c-a0d036bade4f@intel.com \
--to=emil.s.tantilov@intel.com \
--cc=alan.brady@intel.com \
--cc=alice.michael@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=shannon.nelson@amd.com \
--cc=simon.horman@corigine.com \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).