From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8911C43381 for ; Sun, 24 Mar 2019 05:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 657062171F for ; Sun, 24 Mar 2019 05:51:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ui/17JZi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbfCXFsW (ORCPT ); Sun, 24 Mar 2019 01:48:22 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39485 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfCXFsW (ORCPT ); Sun, 24 Mar 2019 01:48:22 -0400 Received: by mail-wr1-f67.google.com with SMTP id j9so6509995wrn.6 for ; Sat, 23 Mar 2019 22:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RTKgIH5V3VSZPRx1xu5yCVniGv0quagAZ9T00gcDT1c=; b=Ui/17JZiGmWfOw79rwHzp6lQd7lNBc35DhLYxRr/v1093tafUsC0vAjs4h30AuEXaB C+Gty/Y0C93ZXHr7GWQmmtXk6ldwj6qv8CAOixaMX5u7hbskEwhlDkXUKQWDtIUf5/ME ZiMvZ0AlNI13zo7caRleoZHo5QYkiSsHeQvY6SK+vT+zU3W9Q0LB/30+Kqbzav2zMYso fN9cpOgNJptn+4wb6ewt9CMkIaU2UElNtoAQduXpu8sZ3COT+ZUrruLo1wV5swHOPL6/ Wc/Hap0lpJ7Vy8wCKSFS07t4C2NFjJo0oHLu6AnqEPw/5I62RzppMOzXHBHuR7GiLz5U +sLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RTKgIH5V3VSZPRx1xu5yCVniGv0quagAZ9T00gcDT1c=; b=onbZbmihDQRVK/LHMaZfQIcbw0ZRSdDVXX+S0wN0laBdQyX1IxUW1tVWuKscMn5qhF 62Fa4j6u7ZVpy3e+twqkYsQr/c8SECerbV92udeC5yaWn/ECjtkf7Y0SSK6Db3KM0LRl h+FffRYJJjoWdPMPvnxWdLqDoni2/Pnh08HgxwLKQXrLzXlLQkNSKb7csXSAUV6y5npD FxH/6xDAXSArzfCgf14UltCasGZfHWnnbTOaqj0Qd5yl2bPo+o3mv/FRNk/lMGdkW5YP 3TgGTzmNcVrX0yPMPeNcb5gzkZUzdTOd49oi/p7GhAI6U7Jgs2s4WPIpssEP7UAKYClS oLKQ== X-Gm-Message-State: APjAAAXxtmnw+Mn2SDFzWyE0UbMISrMNDOgbgwT5QaIv0V7IGDJ5hFRl YEcmH3kQ/zhh0hF8gGL67iI= X-Google-Smtp-Source: APXvYqyRs/0VGKHoJ8pZ7vT4RshZEOANg/KrCegHlZvryiNOf13VAK2vk/4gCIJVeJB2Lf24M58QeQ== X-Received: by 2002:adf:82f0:: with SMTP id 103mr11586790wrc.260.1553406500805; Sat, 23 Mar 2019 22:48:20 -0700 (PDT) Received: from [192.168.8.147] (186.198.23.93.rev.sfr.net. [93.23.198.186]) by smtp.gmail.com with ESMTPSA id u2sm21884730wmc.45.2019.03.23.22.48.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 22:48:19 -0700 (PDT) Subject: Re: [PATCH bpf-next 0/7] bpf: Propagate cn to TCP To: Alexei Starovoitov , Eric Dumazet Cc: brakmo , netdev , Martin Lau , Alexei Starovoitov , Daniel Borkmann , Kernel Team References: <20190323080542.173569-1-brakmo@fb.com> <704cb63c-13cd-f0ed-d546-18e3596bb63d@gmail.com> <20190323154124.gorqpaqex7ihfs6d@ast-mbp> From: Eric Dumazet Message-ID: Date: Sat, 23 Mar 2019 22:48:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190323154124.gorqpaqex7ihfs6d@ast-mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/23/2019 08:41 AM, Alexei Starovoitov wrote: > On Sat, Mar 23, 2019 at 02:12:39AM -0700, Eric Dumazet wrote: >> Please think about offloading the pacing/throttling in the NIC, >> there is no way we will report back to tcp stack instant notificatiions. > > I don't think 'offload to google proprietary nic' is a suggestion > that folks can practically follow. > Very few NICs can offload pacing to hw and there are plenty of limitations. > This patch set represents a pure sw solution that works and scales to millions of flows. offloading is not a unique feature to "Google nic", this is ridiculous. By offloading I meant : Any hop that might not be controlled by linux stack. Think about VM, and think about pacers that can be on various existing NIC, like Mellanox ones. For them, it is trivial to implement L4S style capabilities. Beauty of ECN is that is relies on standard TCP feedback, not on some immediate reaction from one one intermediate hop, sending another signal back to the sender. HTTP 3 is planned to use QUIC (over UDP), we do not want to add TCP-only features in IP fast path. Lets have experimental results first, please ?