Re: [PATCH net-next v2 3/6] net: phy: microchip_t1s: update LAN867x PHY supported revision number

[<Parthiban.Veerasooran@microchip.com>]

Hi Andrew,

On 22/05/23 6:08 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> -#define PHY_ID_LAN867X 0x0007C160
>> +#define PHY_ID_LAN867X_REVB1 0x0007C162
> 
>>   static struct phy_driver microchip_t1s_driver[] = {
>>        {
>> -             PHY_ID_MATCH_MODEL(PHY_ID_LAN867X),
>> -             .name               = "LAN867X",
>> +             PHY_ID_MATCH_EXACT(PHY_ID_LAN867X_REVB1),
>> +             .name               = "LAN867X Rev.B1",
>>                .features           = PHY_BASIC_T1S_P2MP_FEATURES,
>> -             .config_init        = lan867x_config_init,
>> +             .config_init        = lan867x_revb1_config_init,
>>                .read_status        = lan867x_read_status,
>>                .get_plca_cfg       = genphy_c45_plca_get_cfg,
>>                .set_plca_cfg       = genphy_c45_plca_set_cfg,
>> @@ -124,7 +124,7 @@ static struct phy_driver microchip_t1s_driver[] = {
>>   module_phy_driver(microchip_t1s_driver);
>>
>>   static struct mdio_device_id __maybe_unused tbl[] = {
>> -     { PHY_ID_MATCH_MODEL(PHY_ID_LAN867X) },
>> +     { PHY_ID_MATCH_EXACT(PHY_ID_LAN867X_REVB1) },
>>        { }
>>   };
> 
> Maybe i asked this last time...
> 
> What versions actually exist? The old entry would match 0x0007C16X, so
> 0x0007C160 and 0x0007C161, 0x0007C162, if those actually exist. Now
> you are narrowing it down to just 0x0007C162.
> 
> It would be good to comment on this in the commit message, that
> 0x0007C160 and 0x0007C161 never escaped the testing facility and hence
> don't need to be supported.
Ah ok, I will do it in the next version.

Best Regards,
Parthiban V
> 
>          Andrew