From: Jacob Keller <jacob.e.keller@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>, Anil Samal <anil.samal@intel.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<lukasz.czapnik@intel.com>, <leszek.pepiak@intel.com>,
<anthony.l.nguyen@intel.com>, Simon Horman <horms@kernel.org>,
<przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags
Date: Fri, 24 May 2024 14:12:56 -0700 [thread overview]
Message-ID: <df1f4dc1-446c-468f-83ba-8cd27ff39014@intel.com> (raw)
In-Reply-To: <de98ffb7-91fa-4629-8429-8699c9ddea87@molgen.mpg.de>
On 5/24/2024 1:43 PM, Paul Menzel wrote:
> Dear Anil,
>
>
> Thank you for your patch.
>
> Am 24.05.24 um 15:51 schrieb Anil Samal:
>> Current driver implementation for Sideband Queue supports a
>> fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from
>> firmware, Sideband Queue command is used with a different flag.
>>
>> Extend API for Sideband Queue command to use 'flags' as input
>> argument.
>
> Please use `git format-patch`, and not `git show` to send patches. At
> least that is what I assume the unwanted indentation comes from.
>
> […]
>
>
> Kind regards,
>
> Paul
While rebasing, please address the commit message formatting. The rest
of your submission does look like it has come from git format-patch or
git send-email, but we don't want to have this extra indentation in the
commit message, as it would then later be indented even further when the
commit is displayed via git show or git log.
Thanks,
Jake
next prev parent reply other threads:[~2024-05-24 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 13:51 [PATCH iwl-next v3 0/3] ice:Support to dump PHY config, FEC Anil Samal
2024-05-24 13:51 ` [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags Anil Samal
2024-05-24 20:43 ` [Intel-wired-lan] " Paul Menzel
2024-05-24 21:12 ` Jacob Keller [this message]
2024-05-24 13:51 ` [PATCH iwl-next v3 2/3] ice: Implement driver functionality to dump fec statistics Anil Samal
2024-05-24 13:51 ` [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values Anil Samal
2024-06-24 16:28 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-05-24 21:11 ` [PATCH iwl-next v3 0/3] ice:Support to dump PHY config, FEC Jacob Keller
2024-06-08 18:14 ` Samal, Anil
2024-06-10 18:57 ` Jacob Keller
-- strict thread matches above, loose matches on Subject: below --
2024-06-14 12:58 Anil Samal
2024-06-14 12:58 ` [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags Anil Samal
2024-06-24 16:24 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df1f4dc1-446c-468f-83ba-8cd27ff39014@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anil.samal@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leszek.pepiak@intel.com \
--cc=lukasz.czapnik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).