From: John Fastabend <john.fastabend@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [bpf-next PATCH 1/2] bpf: sockmap, free memory on sock close with cork data
Date: Mon, 2 Apr 2018 12:58:15 -0700 [thread overview]
Message-ID: <df37e283-a37d-131c-9450-d80a160073ee@gmail.com> (raw)
In-Reply-To: <20180402195046.10055.11686.stgit@john-Precision-Tower-5810>
On 04/02/2018 12:50 PM, John Fastabend wrote:
> If a socket with pending cork data is closed we do not return the
> memory to the socket until the garbage collector free's the psock
> structure. The garbage collector though can run after the sock has
> completed its close operation. If this ordering happens the sock code
> will through a WARN_ON because there is still outstanding memory
> accounted to the sock.
>
> To resolve this ensure we return memory to the sock when a socket
> is closed.
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
> Fixes: 91843d540a13 ("bpf: sockmap, add msg_cork_bytes() helper")
> ---
Hi Alexei, Daniel,
These two fixes apply against current bpf-next or bpf after
bpf-next is merged. I could resend later I suppose but I think
it makes sense to get these in sooner rather than later.
Thanks,
John
next prev parent reply other threads:[~2018-04-02 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 19:50 [bpf-next PATCH 1/2] bpf: sockmap, free memory on sock close with cork data John Fastabend
2018-04-02 19:50 ` [bpf-next PATCH 2/2] bpf: sockmap, duplicates release calls may NULL sk_prot John Fastabend
2018-04-02 19:58 ` John Fastabend [this message]
2018-04-04 9:14 ` [bpf-next PATCH 1/2] bpf: sockmap, free memory on sock close with cork data Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df37e283-a37d-131c-9450-d80a160073ee@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox