From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH V2 net-next 3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change
Date: Mon, 19 Feb 2018 13:48:24 -0600 [thread overview]
Message-ID: <df4a7a5b-fcd4-d4ea-df2e-adc4a9b3d263@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180219.141608.1994598023015418668.davem@davemloft.net>
On 02/19/2018 01:16 PM, David Miller wrote:
> From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> Date: Sun, 18 Feb 2018 19:34:47 -0600
>
>> @@ -2241,24 +2241,27 @@ static int reset_sub_crq_queues(struct ibmvnic_adapter *adapter)
>> }
>>
>> static void release_sub_crq_queue(struct ibmvnic_adapter *adapter,
>> - struct ibmvnic_sub_crq_queue *scrq)
>> + struct ibmvnic_sub_crq_queue *scrq,
>> + int do_h_free)
>> {
>
> Please use 'bool' and true/false for do_h_free.
Version 3 sent with this update.
-Nathan
>
> Thank you.
>
next prev parent reply other threads:[~2018-02-19 19:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 1:33 [PATCH V2 net-next 0/5] ibmvnic: Make driver resources dynamic Nathan Fontenot
2018-02-19 1:34 ` [PATCH V2 net-next 1/5] ibmvnic: Rename active queue count variables Nathan Fontenot
2018-02-19 1:34 ` [PATCH V2 net-next 2/5] ibmvnic: Move active sub-crq count settings Nathan Fontenot
2018-02-19 1:34 ` [PATCH V2 net-next 3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change Nathan Fontenot
2018-02-19 19:16 ` David Miller
2018-02-19 19:48 ` Nathan Fontenot [this message]
2018-02-19 1:34 ` [PATCH V2 net-next 4/5] ibmvnic: Make napi usage dynamic Nathan Fontenot
2018-02-19 1:35 ` [PATCH V2 net-next 5/5] ibmvnic: Allocate max queues stats buffers Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df4a7a5b-fcd4-d4ea-df2e-adc4a9b3d263@linux.vnet.ibm.com \
--to=nfont@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).