From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34522 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753828AbeBSTsa (ORCPT ); Mon, 19 Feb 2018 14:48:30 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1JJiLXA130519 for ; Mon, 19 Feb 2018 14:48:29 -0500 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g82scdpvw-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 19 Feb 2018 14:48:29 -0500 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Feb 2018 14:48:27 -0500 Subject: Re: [PATCH V2 net-next 3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change To: David Miller Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com, tlfalcon@linux.vnet.ibm.com References: <151900392213.34713.18305096338738012847.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> <151900407751.34713.6473919432097976060.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> <20180219.141608.1994598023015418668.davem@davemloft.net> From: Nathan Fontenot Date: Mon, 19 Feb 2018 13:48:24 -0600 MIME-Version: 1.0 In-Reply-To: <20180219.141608.1994598023015418668.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Sender: netdev-owner@vger.kernel.org List-ID: On 02/19/2018 01:16 PM, David Miller wrote: > From: Nathan Fontenot > Date: Sun, 18 Feb 2018 19:34:47 -0600 > >> @@ -2241,24 +2241,27 @@ static int reset_sub_crq_queues(struct ibmvnic_adapter *adapter) >> } >> >> static void release_sub_crq_queue(struct ibmvnic_adapter *adapter, >> - struct ibmvnic_sub_crq_queue *scrq) >> + struct ibmvnic_sub_crq_queue *scrq, >> + int do_h_free) >> { > > Please use 'bool' and true/false for do_h_free. Version 3 sent with this update. -Nathan > > Thank you. >