From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17B74423A6B for ; Wed, 3 Jun 2026 08:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780476884; cv=none; b=PYvXZaUl9XTiTVEX6RnWuYV8EkJXoD03XQJrm0CKBAFD3nBAFCGOt9kxod0OxSAgrV48SlyXYRAGBna+i1bfTIzx0p8l6yAGmvHqCyPl2b95CDyNfhNEG5FEm7yQsSE2UKQpUQQBtt8qUFoG90To6+TigF7Wagm9UYoHnSlJ15o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780476884; c=relaxed/simple; bh=rRGg//Y4nDsQNy1FHaP+pR67XmCWoxS8P2u7l41taE8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gsFWMeURRKMyhiYHZDQksPtgXxjzEqbEKAXYTNOaDjOtANyoB0iZH7tmjqC/MeetDT4mLGO9whlm9GaAHMwgce1DI4PCt3aFTTJVveWAS7keUyn40cHiNjIVQNKhUSY6D/ycHi3r/6fgK+UGTCrA2x6S7AOiVvlcOR4dThQnlyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WKo0LZKi; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WKo0LZKi" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780476879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+nEt0ZnblfZVUOOxbnF3behQcy+9xXOn6KT8LbzXD30=; b=WKo0LZKiRqDuTCbIM/wzF1bXcZAqnnILnOg4XhNBDPglVs8TNIDTZk9ixjDq8EzZUbbwJh KRKc0s8/iIEo1vJ6x5Hl0FUsbdwYbyFEL7DSUK85zoLte+Zkf9ux5kT56UhLcipu2LKuEc 5lg2LZL0mJjih+10smRnPzLuvWF+myg= Date: Wed, 3 Jun 2026 16:54:24 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] flow_dissector: fix uninit-value in __skb_flow_dissect() for ETH_ADDRS To: Eric Dumazet , "Zhou, Yun" Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260603030810.3593625-1-yun.zhou@windriver.com> <2fe4890d-842b-4595-b0db-6859579ca6ef@windriver.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jiayuan Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 6/3/26 4:33 PM, Eric Dumazet wrote: > On Wed, Jun 3, 2026 at 1:16 AM Zhou, Yun wrote: >> >> >> On 6/3/26 13:44, Eric Dumazet wrote: >>> CAUTION: This email comes from a non Wind River email account! >>> Do not click links or open attachments unless you recognize the sender and know the content is safe. >>> >>> On Tue, Jun 2, 2026 at 8:08 PM Yun Zhou wrote: >>> Please add a Closes: tag >> I will add a Closes link in v2. >> Closes: https://syzkaller.appspot.com/bug?extid=fa2f5b1fb06147be5e16 >>> I found some not relevant syzbot report : >>> >>> https://lore.kernel.org/netdev/6a196faf.c16d89a8.217f2c.0002.GAE@google.com/ >> This should be the same issue. And it can be reproduced by >> https://syzkaller.appspot.com/text?tag=ReproC&x=12924152580000 > Please investigate which device allowed to send an Ethernet packet > smaller than the ethernet header. > > We do not want to add tests all over the places, we should fix the origin. > > Look for dev->min_header_len > > Thanks. It's TUN. I think we should reject loading "tc filter ... flower eth_dst aa:bb:cc:dd:ee:ff ... " if dev->hard_header_len < sizeof(flow_dissector_key_eth_addrs)