Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jason Winter <jjx@live.nl>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, linux@rainbow-software.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH net] net: usb: cx82310_eth: bound partial-frame remainder by current skb length
Date: Fri, 14 Aug 2026 22:11:56 +0200	[thread overview]
Message-ID: <dfa12d31-275f-426f-8cb2-594a823dbd82@lunn.ch> (raw)
In-Reply-To: <BESP194MB28324DC870B7DE2E694CCEEEB8DA2@BESP194MB2832.EURP194.PROD.OUTLOOK.COM>

On Fri, Aug 14, 2026 at 09:08:14PM +0200, Jason Winter wrote:
> When a frame straddles two bulk URBs, cx82310_rx_fixup() stores the
> number of bytes still expected in dev->partial_rem and on the next call
> memcpy()s that many bytes from the new skb without checking that the new
> URB actually delivered that much data. A malicious device

So this is somewhat theoretical. Maybe less so than average, since
this is a USB dongle, but still, does it bother people?

Please drop the Fixes: tag and post for net-next.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

    Andrew

---
pw-bot: cr

      reply	other threads:[~2026-08-14 20:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 19:08 [PATCH net] net: usb: cx82310_eth: bound partial-frame remainder by current skb length Jason Winter
2026-08-14 20:11 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfa12d31-275f-426f-8cb2-594a823dbd82@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jjx@live.nl \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox