Re: [PATCH net-next v2 0/7] hardware pacing offload

[Mohsin Bashir <mohsin.bashr@gmail.com>]

On 7/22/26 1:43 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
> 
> Enable safe hardware pacing offload on a first device (idpf), plus support.
> 
> - Add ethtool support for admin control over the device feature
> - Add device support to the idpf driver
> 
> Besides the main feature, also
> 
> - Small optimization to FQ offload: avoid unnecessary ktime_.._get().
> - Expand so_txtime drv-net test with hw offload testcases.
> - Expand pktgen with txtime feature.
> 
> Details in the individual patches.

Hi Willem,
Thanks for this. It'll definitely be useful for other drivers with 
native device EDT support. I left a few minor comments on the individual 
patches.
> 
> v1: https://lore.kernel.org/netdev/20260706133433.3142805-1-willemdebruijn.kernel@gmail.com/
> 
> Willem de Bruijn (7):
>    net: ethtool: add hardware pacing offload support to rings
>    net_sched: sch_fq: clear past skb->tstamp if offloading pacing
>    idpf: support pacing offload
>    selftests: drv-net: refactor so_txtime errqueue handling
>    selftests: drv-net: in so_txtime tell apart sw from hw pacing
>    selftests: drv-net: extend so_txtime with hw offload
>    net: pktgen: add support for SO_TXTIME
> 
>   Documentation/netlink/specs/ethtool.yaml      |   6 +
>   .../networking/net_cachelines/net_device.rst  |   3 +-
>   .../net/ethernet/intel/idpf/idpf_ethtool.c    |   3 +-
>   drivers/net/ethernet/intel/idpf/idpf_lib.c    |   5 +
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c   |  65 +++++++-
>   drivers/net/ethernet/intel/idpf/idpf_txrx.h   |   2 +
>   include/linux/ethtool.h                       |   6 +
>   include/linux/netdevice.h                     |   6 +-
>   .../uapi/linux/ethtool_netlink_generated.h    |   2 +
>   net/core/pktgen.c                             |  93 ++++++++++-
>   net/core/rtnetlink.c                          |   2 +-
>   net/ethtool/common.c                          |   3 +
>   net/ethtool/netlink.h                         |   2 +-
>   net/ethtool/rings.c                           |  30 +++-
>   net/sched/sch_fq.c                            |  21 ++-
>   tools/testing/selftests/drivers/net/settings  |   1 +
>   .../testing/selftests/drivers/net/so_txtime.c | 147 +++++++++++++-----
>   .../selftests/drivers/net/so_txtime.py        |  72 ++++++++-
>   18 files changed, 408 insertions(+), 61 deletions(-)
>   create mode 100644 tools/testing/selftests/drivers/net/settings
>