From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792673903; b=T/kRFXVn49tCpG3Fz4TjP+/XiOt9Zfdfsu3M9JQCtJWGVGYg01QE3fwL6CQdnac8kssU lyAdhmSE5gZJWsV2+Hu0ofk6XCdxFHpCee7WwNOcLiuwP98B2Lgqelr79sndYUkFPuC7A foRMIa+5v6dTbw1qgVS4CeZZlJ5YwpavW/9V42wQMFBF2oLKw7dXDx1RIPOO4O0akSZGx aI/G72b1ZYGykM7ex7fCcM9LSwzhVaMz4PwjMAitfV2QkKKiI1SyObvVr293ySG+gxnql hymb+epOPWSnZ93tGeXpDoaOsvONUGyL7F4cPGTOcSHLQCGrpMdSHjk2I+ZxtJzPxDg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792673903; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To:X-Mailer: X-Mutt-Fcc; bh=VrgZwsKhKHkmEbVDierK3hRSfuUB2Tabjw1XdPoU1r8=; b=m+y6AlSAwbAMXRgofv+kddQQapobTk7GUx/tjb/8HpgTIFKKy/UfZlNiYPUagesvnqVE 15E1vcWJjTpmZfVxpqhxCmxylhQ/g8PgFcIY72o8HQu6I5biindeu+JmyGpwGNGsnB8ZM p56nAa0qvb6h93RDLzRAwDvWq3my5qoOryKZ0dQipohovDbzNTeSqgcTWUVME3zgpeEHh +WWc0qoL2pzjR8DieUDybVoZz59nK76YOeiPRnDObgurJfvNDl+KeKoTdYsuz/5f7Q8wd um2GUARX8m3LoLoEtmpRd+jQHcrxBBAnc6gDvGSnJlevqP7l3Hzk6w5kS5jP9qDuoew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NJRgqxpE; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b="Iiz/Z/nE"; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1B7960A2604 for ; Thu, 22 Oct 2026 12:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C1B7960A2604 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NJRgqxpE; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=Iiz/Z/nE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792673901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VrgZwsKhKHkmEbVDierK3hRSfuUB2Tabjw1XdPoU1r8=; b=NJRgqxpE/T/kE1Bx0JRlQey94S+plvzFSmS4pm4qPBecCvSD0BqcUf1yFBfTJBrMN60ckS /RlN39QYmfCS+YqvVwArCX28CJgx2VLZPF8O6wM1qLCRuTGCOK/5Ss68fBZTGDH0e8V41y eURehqf3CvcNbKNpXJHmDtT8bSRs4uk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-aEYdSZHYN7qmeh4ucIr96w-1; Thu, 22 Oct 2026 12:58:20 +0000 X-MC-Unique: aEYdSZHYN7qmeh4ucIr96w-1 X-Mimecast-MFC-AGG-ID: aEYdSZHYN7qmeh4ucIr96w_1792673899 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a16faefac0so11475205e9.0 for ; Thu, 22 Oct 2026 05:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792673899; x=1793278699; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VrgZwsKhKHkmEbVDierK3hRSfuUB2Tabjw1XdPoU1r8=; b=Iiz/Z/nEwH+UuHp58dowtNajoOUR+oG4R1ELWDDyIlwiDLMonD4UJqYGxYvZQFr1/X TfWMCRQYef1X5n7ZOq0FZpdfsCBFUIXMvEETukQ+joFImbS1lZS0PvoDONZP1h9RhiFC PqLVujq3J7EuIJHZhwct1BEQPe7Ba3NPV+VPtFyCkkuToZ4vI2HwwEqmaZ3cshFWasyg Bxf1fVhQ3czaHOCjJsTgdUWsAcn6qhp+8lzq7O9yzm7dAvUuELlR1gsvpqwRU9NaQpcX wRuWqOMI2Os+ZyoheOdaC2ohUQDH3uIkDSxg1I2HJf5sfP84g2F9NLbPGNMqC5ZWYJWv UkWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792673899; x=1793278699; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VrgZwsKhKHkmEbVDierK3hRSfuUB2Tabjw1XdPoU1r8=; b=z6/cc8XZKEmyGIIBFsB6Rl+ue7r/C/SHWkKCdB8qjuxTL6aOjYlmRT9HypzF61xyGH chmEvH/md4mO/deEVrNaWwmw9nC8aqrcMRAckOwtHtVgVnIQNPkKM68YHZNybjwA8EH2 /JJxxRbqjCs6NPZVh6IZH09ES33ZHCe632Sx/cftL+3vwrDRRlYut2gCZtPw/bHfTPA0 Nu6D+f+SKXynGMYBVqQtLyqbPVIAraCtzbTUCFvXsg++VHzn5G3fWIhHOde47GXu1QsV OKWRlQbm4WOc7yOdOfDNyxT58Wo71m2vU5xnqDivnwwl7CxyIXQo3GkwLPkDVunJBeKk HX6Q== X-Forwarded-Encrypted: i=1; AKwUvBwgcL1Bz8aFSka5Pm82NpP26KkdgS4sTG01rVMDcfk4DKekgGy67pE0furjmDa94Szq4gRGcGQ=@vger.kernel.org X-Gm-Message-State: AFq9FYLp6pPerLXL0QV9cFDN3QQMRloRM33HRrk9ZpaK+q3A7YgrvPaq kbwTcNry4xYllshb5AQPCSeRN2v5eWOIj/C5GVP6wW35+JURt6ZKh5gjSIXZQjO0sdWZ4pvt7tD eSns5cKNyiGg0zUfbsxeuwjxrAZaZZkAU1zQgMVxVtneomQHMV6YzCoyh0w== X-Gm-Gg: AYBFou0xv//JZMHLnBtTNKaMOLwjcSsbnCMbicmIs3HyVru542eGUlG5902I38vDN1x ha9MIlUKVZLeQ8EKm1NMXnBHB5LHrZS3//J1br1NlJTj2ewX6UjAqOD5N7e8w2KTBLnfLH3YQmr v0mXQsMviismZ1sFPLI4nC6fDVlDOZJVEsc1o85uoqZgYibjRudDHRB4OOIa9A5AH5qnuQ3TkVY jYd+6S+pHgZCN6/n4Uc5wvN7D8eCXt3Hog1O53BoDuN5oVPQJvIxTKB9Idok6GOjWYzL0Ld5JZO zUOdj3VygrRXCJ9FFx9PNj4o5vbkce/5l8VjJJUvCI7C7xYGDvQ/6cBUqyXii/Pr5bE= X-Received: by 2002:a05:600c:3513:b0:4a1:cedc:ab49 with SMTP id 5b1f17b1804b1-4a1fdd1e97emr110652305e9.31.1792673899243; Thu, 22 Oct 2026 05:58:19 -0700 (PDT) X-Received: by 2002:a05:600c:3513:b0:4a1:cedc:ab49 with SMTP id 5b1f17b1804b1-4a1fdd1e97emr110651585e9.31.1792673898550; Thu, 22 Oct 2026 05:58:18 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1536:fc00:b838:383:1c7:6e81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e2583522esm12561180f8f.35.2026.10.22.05.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 05:58:16 -0700 (PDT) Date: Thu, 22 Oct 2026 08:58:14 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Willem de Bruijn , Chris Arges , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Phil Sutter , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Max Krasnyansky , Rusty Russell Subject: [PATCH net v5 3/7] virtio_net: parse tunnel csum_start little-endian Message-ID: References: X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.51.2.2891.g4157995a80.dirty X-Mutt-Fcc: =sent All tunnel related virtio features are > 32, so none of this functionality can be enabled on legacy mixed-endian device. Accordingly, all tunnel header fields, csum_start included, are little-endian. The nested virtio net header import parses csum_start that way, but the inner transport offset is parsed with the endianness specified by the interface. If tun is misconfigured to legacy big-endian mode while the tunnel features are enabled, the two parses of this field disagree, and the value stored in skb->inner_transport_header - which is only bounds-checked from below - can point past the end of the packet, where GSO segmentation later dereferences it. To fix, parse the field little-endian in both places. Fixes: a2fb4bc4e2a6 ("net: implement virtio helpers to handle UDP GSO tunneling.") Cc: Paolo Abeni Signed-off-by: Michael S. Tsirkin --- include/linux/virtio_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h index d6466f96cdd0..013c6c7e2dea 100644 --- a/include/linux/virtio_net.h +++ b/include/linux/virtio_net.h @@ -324,7 +324,7 @@ virtio_net_hdr_tnl_to_skb(struct sk_buff *skb, inner_l3min = virtio_l3min(inner_isv6); outer_l3min = ETH_HLEN + virtio_l3min(outer_isv6); - inner_th = __virtio16_to_cpu(little_endian, hdr->csum_start); + inner_th = __virtio16_to_cpu(true, hdr->csum_start); inner_nh = le16_to_cpu(vhdr->inner_nh_offset); outer_th = le16_to_cpu(vhdr->outer_th_offset); if (outer_th < outer_l3min || -- MST