From: David Ahern <dsahern@kernel.org>
To: shiming cheng <shiming.cheng@mediatek.com>,
willemdebruijn.kernel@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: netdev@vger.kernel.org, lena.wang@mediatek.com
Subject: Re: [PATCH] ipv6: socket SO_BINDTODEVICE lookup routing fail without IPv6 rule.
Date: Thu, 2 Jan 2025 08:57:17 -0700 [thread overview]
Message-ID: <dfd37ca0-14c6-4cc1-8fae-f1aa2d23e148@kernel.org> (raw)
In-Reply-To: <20250102095114.25860-1-shiming.cheng@mediatek.com>
On 1/2/25 2:51 AM, shiming cheng wrote:
> When using socket IPv6 with SO_BINDTODEVICE, if IPv6 rule is not
> matched, it will return ENETUNREACH. In fact, IPv4 does not behave
> this way. IPv4 prioritizes looking up IP rules for routing and
> forwarding, if not matched it will use socket-bound out interface
> to send packets. The modification here is to make IPv6 behave the
> same as IPv4. If IP rule is not found, it will also use
> socket-bound out interface to send packts.
>
Please create test cases for IPv4 and IPv6 showing the problem - what
you are configuring and the expected result.
Also, commit messages should align with first column unless there is a
reason for an indentation.
prev parent reply other threads:[~2025-01-02 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 9:51 [PATCH] ipv6: socket SO_BINDTODEVICE lookup routing fail without IPv6 rule shiming cheng
2025-01-02 12:12 ` kernel test robot
2025-01-02 13:03 ` kernel test robot
2025-01-02 13:48 ` kernel test robot
2025-01-02 15:57 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd37ca0-14c6-4cc1-8fae-f1aa2d23e148@kernel.org \
--to=dsahern@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lena.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shiming.cheng@mediatek.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).