From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 0/2] net: phy: make PHY_HALTED a transition state to PHY_READY
Date: Wed, 19 Dec 2018 07:50:43 +0100 [thread overview]
Message-ID: <dfe24ccd-3fd2-5641-6599-9f48260b415f@gmail.com> (raw)
PHY_HALTED and PHY_READY both are non-started states and quite similar.
Major difference is that phy_start() changes from PHY_HALTED to
PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does).
There's no guarantee that PHY registers are completely untouched when
waking up from power-down, e.g. after system suspend. Therefore it's
safer to reconfigure aneg also when starting from PHY_HALTED. This can
be achieved and state machine made simpler by making PHY_HALTED going
to PHY_READY after having stopped everything. Then the only way up is
over PHY_UP. As part of the change PHY_HALTED is renamed to PHY_HALT to
reflect that it is a transition state.
After this change states PHY_RESUMING and PHY_CHANGELINK can be
removed.
Heiner Kallweit (2):
net: phy: make PHY_HALTED a transition state to PHY_READY
net: phy: remove states PHY_CHANGELINK and PHY_RESUMING
drivers/net/phy/phy.c | 45 ++++++++++++++++---------------------------
include/linux/phy.h | 24 ++++++-----------------
2 files changed, 23 insertions(+), 46 deletions(-)
--
2.20.1
next reply other threads:[~2018-12-19 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 6:50 Heiner Kallweit [this message]
2018-12-19 6:53 ` [PATCH net-next 1/2] net: phy: make PHY_HALTED a transition state to PHY_READY Heiner Kallweit
2018-12-19 18:32 ` Florian Fainelli
2018-12-19 20:13 ` Heiner Kallweit
2018-12-19 6:55 ` [PATCH net-next 2/2] net: phy: remove states PHY_CHANGELINK and PHY_RESUMING Heiner Kallweit
2018-12-20 0:20 ` [PATCH net-next 0/2] net: phy: make PHY_HALTED a transition state to PHY_READY David Miller
2018-12-21 3:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe24ccd-3fd2-5641-6599-9f48260b415f@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).