From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Subject: Re: [PATCH] net: ethernet: sun: remove redundant variables adv and lpa Date: Thu, 5 Jul 2018 11:50:01 +0100 Message-ID: References: <20180705093732.21650-1-colin.king@canonical.com> <20180705.193315.2106014813802269928.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180705.193315.2106014813802269928.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 05/07/18 11:33, David Miller wrote: > From: Colin King > Date: Thu, 5 Jul 2018 10:37:32 +0100 > >> From: Colin Ian King >> >> Variables adv and lpa are being assigned but are never used hence they >> are redundant and can be removed. >> >> Cleans up clang warnings: >> warning: variable 'lpa' set but not used [-Wunused-but-set-variable] >> warning: variable 'adv' set but not used [-Wunused-but-set-variable] >> >> Signed-off-by: Colin Ian King > > I think you can safely remove the register reads too, so please > do so. Just to clarify, just the MII_ADVERTISE and MII_LPA, or both these AND also MII_ESTATUS too? > > Thanks. >