Netdev List
 help / color / mirror / Atom feed
From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: devnull+corey.leavitt.info@kernel.org
Cc: andrew+netdev@lunn.ch, andrew@lunn.ch, corey@leavitt.info,
	davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com,
	kory.maincent@bootlin.com, kuba@kernel.org,
	linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
	netdev@vger.kernel.org, o.rempel@pengutronix.de,
	pabeni@redhat.com
Subject: Re: [PATCH RFC net-next 4/4] net: phy: own phydev->psec via PSE notifier and remove fwnode_mdio hook
Date: Thu, 28 May 2026 21:15:43 +0200	[thread overview]
Message-ID: <e00048dd-1ed3-40c3-9912-59bccf015ad5@gmail.com> (raw)
In-Reply-To: <20260423-pse-notifier-decouple-v1-4-86ed750a9d62@leavitt.info>

Hi,

this patch seems to cause a deadlock with PHYs which provide SFP 
ports. Noticed this downstream in OpenWrt with Realtek RTL8214FC
using an extension to the upstream driver [1].

I suspect the deadlock happens because phy_device_register takes
rtnl_lock with this patch. But further down in the call chain,
phy_sfp_probe is called, calling sfp_bus_add_upstream which in turn
tries to take rtnl_lock again.

While the downstream driver part still calls phy_sfp_probe itself,
backporting the phy_port changes to 6.18 and adjusting the driver
doesn't help. If I got it correctly, the phy_sfp_probe just moves
into phylib core but still causes the deadlock.

Kind regards,
Jonas Jelonek

[1] https://git.openwrt.org/openwrt/openwrt/tree/target/linux/realtek/files-6.18/drivers/net/phy/realtek/realtek_multiport.c

  parent reply	other threads:[~2026-05-28 19:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  7:42 [PATCH RFC net-next 0/4] net: pse-pd: decouple controller lookup from MDIO probe Corey Leavitt via B4 Relay
2026-04-23  7:42 ` [PATCH RFC net-next 1/4] net: pse-pd: scope pse_control regulator handle to kref lifetime Corey Leavitt via B4 Relay
2026-04-24  8:36   ` Kory Maincent
2026-04-23  7:42 ` [PATCH RFC net-next 2/4] net: pse-pd: add notifier chain for controller lifecycle events Corey Leavitt via B4 Relay
2026-04-23  7:42 ` [PATCH RFC net-next 3/4] net: pse-pd: fire lifecycle events on controller register/unregister Corey Leavitt via B4 Relay
2026-04-23  7:42 ` [PATCH RFC net-next 4/4] net: phy: own phydev->psec via PSE notifier and remove fwnode_mdio hook Corey Leavitt via B4 Relay
2026-04-24 12:36   ` Kory Maincent
2026-05-28 19:15   ` Jonas Jelonek [this message]
2026-04-23  9:05 ` [PATCH RFC net-next 0/4] net: pse-pd: decouple controller lookup from MDIO probe Kory Maincent
2026-04-23  9:48   ` Corey Leavitt
2026-04-24 12:41     ` Kory Maincent
2026-04-26 21:25       ` Carlo Szelinsky
2026-05-02 20:10       ` Carlo Szelinsky
2026-05-05  4:36         ` Corey Leavitt
2026-06-15 18:08           ` Carlo Szelinsky
2026-06-16 16:42             ` Kory Maincent
  -- strict thread matches above, loose matches on Subject: below --
2026-04-23  7:22 Corey Leavitt
2026-04-23  7:23 ` [PATCH RFC net-next 4/4] net: phy: own phydev->psec via PSE notifier and remove fwnode_mdio hook Corey Leavitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e00048dd-1ed3-40c3-9912-59bccf015ad5@gmail.com \
    --to=jelonek.jonas@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=corey@leavitt.info \
    --cc=davem@davemloft.net \
    --cc=devnull+corey.leavitt.info@kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox