From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xin Long Subject: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning Date: Thu, 27 Aug 2015 05:03:24 +0800 Message-ID: Cc: mleitner@redhat.com, davem@davemloft.net, vyasevic@redhat.com To: network dev Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:33327 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbbHZVD1 (ORCPT ); Wed, 26 Aug 2015 17:03:27 -0400 Received: by pacti10 with SMTP id ti10so99676437pac.0 for ; Wed, 26 Aug 2015 14:03:27 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), it will not be safe. so add detection in sctp_verify_asconf() to check the address parameter is in the beginning, or return false to send abort. Signed-off-by: Xin Long Signed-off-by: Vlad Yasevich --- net/sctp/sm_make_chunk.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index 06320c8..f3fc881 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c @@ -3132,12 +3132,14 @@ bool sctp_verify_asconf(const struct sctp_association *asoc, case SCTP_PARAM_IPV4_ADDRESS: if (length != sizeof(sctp_ipv4addr_param_t)) return false; - addr_param_seen = true; + if (param.v == addip->addip_hdr.params) + addr_param_seen = true; break; case SCTP_PARAM_IPV6_ADDRESS: if (length != sizeof(sctp_ipv6addr_param_t)) return false; - addr_param_seen = true; + if (param.v == addip->addip_hdr.params) + addr_param_seen = true; break; case SCTP_PARAM_ADD_IP: case SCTP_PARAM_DEL_IP: -- 2.1.0