From mboxrd@z Thu Jan  1 00:00:00 1970
From: Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad
 arguments
Date: Thu, 23 Aug 2018 18:48:25 +0100
Message-ID: <e00a163d-4574-1908-54ec-2b7c5d69508b@netronome.com>
References: <20180823164625.5410-1-quentin.monnet@netronome.com>
 <7d223b75-59ae-2b8f-ff09-7f800c6228bf@cogentembedded.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
        netdev@vger.kernel.org, oss-drivers@netronome.com
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:33781 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726636AbeHWVTR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 23 Aug 2018 17:19:17 -0400
Received: by mail-wm0-f67.google.com with SMTP id i134-v6so2619467wmf.0
        for <netdev@vger.kernel.org>; Thu, 23 Aug 2018 10:48:27 -0700 (PDT)
In-Reply-To: <7d223b75-59ae-2b8f-ff09-7f800c6228bf@cogentembedded.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

2018-08-23 20:35 UTC+0300 ~ Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com>
> Hello!
> 
> On 08/23/2018 07:46 PM, Quentin Monnet wrote:
> 
>> When command line parsing fails in the while loop in do_event_pipe()
>> because the number of arguments is incorrect or because the keyword is
>> unknown, an error message is displayed, but bpfool
> 
>    bp-who? ;-)
> 
>> remains stucked in
> 
>    Stuck.
> 
>> the loop. Make sure we exit the loop upon failure.
>>
>> Fixes: f412eed9dfde ("tools: bpftool: add simple perf event output reader")
>> Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
>> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> [...]
> 
> MBR, Sergei

Thanks Sergei! The patch has been applied so I cannot fix these, but
I'll make sure to give an additional pass to my future commit logs…

Best,
Quentin