From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E41C43381 for ; Thu, 28 Feb 2019 00:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06E3B214D8 for ; Thu, 28 Feb 2019 00:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="Bftn6ou2"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="E5ba7sXp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730254AbfB1Akf (ORCPT ); Wed, 27 Feb 2019 19:40:35 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:48684 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730131AbfB1Akf (ORCPT ); Wed, 27 Feb 2019 19:40:35 -0500 Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1S0XdCL018997; Wed, 27 Feb 2019 16:40:13 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=rB28FWkZ8uQiuhNLyMihggsBK7D8fxGk2r9t91Af3jo=; b=Bftn6ou2e7jDgt2l5tPFCleSb3Px5Hmoi8MpaJAh9xYECtjqcw9rWY/aBHrheV/cEfOp CuuSQDLbN73uzm0wU5m3Es2D276Mgs7D8wLZzZkMP4Q6X3q58kaAPHlhwDmu6CAgLKB7 xyfimt/bBhQ6Mhrtq1jYXYCnSzmyG2EmjS8= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2qx28t0hft-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 27 Feb 2019 16:40:13 -0800 Received: from prn-mbx02.TheFacebook.com (2620:10d:c081:6::16) by prn-hub05.TheFacebook.com (2620:10d:c081:35::129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Wed, 27 Feb 2019 16:40:10 -0800 Received: from prn-hub02.TheFacebook.com (2620:10d:c081:35::126) by prn-mbx02.TheFacebook.com (2620:10d:c081:6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Wed, 27 Feb 2019 16:40:10 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3 via Frontend Transport; Wed, 27 Feb 2019 16:40:10 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rB28FWkZ8uQiuhNLyMihggsBK7D8fxGk2r9t91Af3jo=; b=E5ba7sXpquPbazdm8HPw2Sey0Z9WFnAkevbGCpsD1vwcwhPZTI5EshA1kD5VnXGXgzcQ4Xxo2UK1V6//Cfx6VMMskolZUqkQvNa1nXy1IJ6sPIl50SgL4SMS+GaxhVBKZA78G3UtY+tdLvF4n6564P5Q6dszB3XOyoyDWZsOHOM= Received: from BYAPR15MB3384.namprd15.prod.outlook.com (20.179.59.17) by BYAPR15MB2518.namprd15.prod.outlook.com (20.179.154.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.16; Thu, 28 Feb 2019 00:40:08 +0000 Received: from BYAPR15MB3384.namprd15.prod.outlook.com ([fe80::d051:e43:9e14:b94]) by BYAPR15MB3384.namprd15.prod.outlook.com ([fe80::d051:e43:9e14:b94%4]) with mapi id 15.20.1665.015; Thu, 28 Feb 2019 00:40:08 +0000 From: Yonghong Song To: Andrii Nakryiko CC: "netdev@vger.kernel.org" , Alexei Starovoitov , Daniel Borkmann , Kernel Team Subject: Re: [PATCH bpf-next 1/2] bpf: set inner_map_meta->spin_lock_off correctly Thread-Topic: [PATCH bpf-next 1/2] bpf: set inner_map_meta->spin_lock_off correctly Thread-Index: AQHUzuKus7FvQNEnK0uSAK8cTFdMyaX0TByA//+GpoCAAIh/gIAAA00A Date: Thu, 28 Feb 2019 00:40:08 +0000 Message-ID: References: <20190227212256.3856416-1-yhs@fb.com> <20190227212256.3856473-1-yhs@fb.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR07CA0042.namprd07.prod.outlook.com (2603:10b6:a03:60::19) To BYAPR15MB3384.namprd15.prod.outlook.com (2603:10b6:a03:10e::17) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2620:10d:c090:200::3:6d72] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc512fc1-edbe-485b-3ae8-08d69d1549d7 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2518; x-ms-traffictypediagnostic: BYAPR15MB2518: x-microsoft-exchange-diagnostics: 1;BYAPR15MB2518;20:UFZvz3kE3reK0xUmf4zxdzOMQr2W914leHsqDw8PHRWqZVD6L9l+qbjg+CrgHKr+9h9XfSqxXqrMYpLQzKIooH3jYAKd+KcgfAn7ZeoOl8ey+6cGRbEYdqqiQgQ8UxftZfYI1eRk3sNvIiTfpn0TvRsdhffj8b/3lNdKwaPvVMY= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(376002)(136003)(39860400002)(366004)(396003)(199004)(189003)(4326008)(2906002)(256004)(5660300002)(229853002)(6116002)(6512007)(14444005)(6486002)(6436002)(6246003)(8936002)(31696002)(81156014)(8676002)(478600001)(81166006)(53936002)(14454004)(68736007)(36756003)(102836004)(106356001)(105586002)(305945005)(7736002)(71190400001)(71200400001)(52116002)(386003)(86362001)(6506007)(97736004)(53546011)(46003)(6916009)(476003)(2616005)(93886005)(54906003)(186003)(25786009)(31686004)(446003)(11346002)(99286004)(316002)(486006)(76176011);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2518;H:BYAPR15MB3384.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JSzTkvzf0K0UBsIGHHkoxVYGlS0+V2RIpM41G7kg83ZZj8VBPlBqan45K6xxG4xjzlChY7aDCmoMTGEvagBsjtA513fj85O73RCa2PTLtz4FAhJbWGRQZyuI6VYZ/G9bQQudkylsGFQYqtXO/znJIUNv4xCjBB8lHPH7s3awh2r/up/PqJrSb6xHKX4fWylQ/4xnekP+relUFY814cCNjiuaoYVEjox5N1ypH8PNbNJ1IzY5ueX4wI5uSwZJ3IKBpAMAH//3z6zNZ55Dymzkk2A1AGHJ2QaLoQHlNQRTlXK+r7a7eYWdKkiQrVTLvnWXP4gtNuXRJuzhFMYS9KcKED9PmO+SfhUKW04BaljEHiZ/mN/aW66k25kb0hDxuMvgczu3lctnSzZNVY/jHLzjo/gAfZFQ8Be4BmF9syFxou4= Content-Type: text/plain; charset="utf-8" Content-ID: <235BAAD4732D9C4BB30AF60F2C1A4F43@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dc512fc1-edbe-485b-3ae8-08d69d1549d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 00:40:08.0801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2518 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-27_15:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org DQoNCk9uIDIvMjcvMTkgNDoyOCBQTSwgQW5kcmlpIE5ha3J5aWtvIHdyb3RlOg0KPiBPbiBXZWQs IEZlYiAyNywgMjAxOSBhdCA0OjE5IFBNIFlvbmdob25nIFNvbmcgPHloc0BmYi5jb20+IHdyb3Rl Og0KPj4NCj4+DQo+Pg0KPj4gT24gMi8yNy8xOSAzOjM0IFBNLCBBbmRyaWkgTmFrcnlpa28gd3Jv dGU6DQo+Pj4gT24gV2VkLCBGZWIgMjcsIDIwMTkgYXQgMToyMyBQTSBZb25naG9uZyBTb25nIDx5 aHNAZmIuY29tPiB3cm90ZToNCj4+Pj4NCj4+Pj4gQ29tbWl0IGQ4MzUyNWNhNjJjZiAoImJwZjog aW50cm9kdWNlIGJwZl9zcGluX2xvY2siKQ0KPj4+PiBpbnRyb2R1Y2VkIGJwZl9zcGluX2xvY2sg YW5kIHRoZSBmaWVsZCBzcGluX2xvY2tfb2ZmDQo+Pj4+IGluIGtlcm5lbCBpbnRlcm5hbCBzdHJ1 Y3R1cmUgYnBmX21hcCBoYXMgdGhlIGZvbGxvd2luZw0KPj4+PiBtZWFuaW5nOg0KPj4+PiAgICAg Pj0wIHZhbGlkIG9mZnNldCwgPDAgZXJyb3INCj4+Pj4NCj4+Pj4gRm9yIGV2ZXJ5IG1hcCBjcmVh dGVkLCB0aGUga2VybmVsIHdpbGwgZW5zdXJlDQo+Pj4+IHNwaW5fbG9ja19vZmYgaGFzIGNvcnJl Y3QgdmFsdWUuDQo+Pj4+DQo+Pj4+IEN1cnJlbnRseSwgYnBmX21hcC0+c3Bpbl9sb2NrX29mZiBp cyBub3QgY29waWVkDQo+Pj4+IGZyb20gdGhlIGlubmVyIG1hcCB0byB0aGUgbWFwX2luX21hcCBp bm5lcl9tYXBfbWV0YQ0KPj4+PiBkdXJpbmcgYSBtYXBfaW5fbWFwIHR5cGUgbWFwIGNyZWF0aW9u LCBzbw0KPj4+PiBpbm5lcl9tYXBfbWV0YS0+c3Bpbl9sb2NrX29mZiA9IDAuDQo+Pj4+IFRoaXMg d2lsbCBnaXZlIHZlcmlmaWVyIHdyb25nIGluZm9ybWF0aW9uIHRoYXQNCj4+Pj4gaW5uZXJfbWFw IGhhcyBicGZfc3Bpbl9sb2NrIGFuZCB0aGUgYnBmX3NwaW5fbG9jaw0KPj4+PiBpcyBkZWZpbmVk IGF0IG9mZnNldCAwLiBBbiBhY2Nlc3MgdG8gb2Zmc2V0IDANCj4+Pj4gb2YgYSB2YWx1ZSBwb2lu dGVyIHdpbGwgdHJpZ2dlciB0aGUgZm9sbG93aW5nIGVycm9yOg0KPj4+PiAgICAgIGJwZl9zcGlu X2xvY2sgY2Fubm90IGJlIGFjY2Vzc2VkIGRpcmVjdGx5IGJ5IGxvYWQvc3RvcmUNCj4+Pj4NCj4+ Pj4gVGhpcyBwYXRjaCBmaXhlZCB0aGUgaXNzdWUgYnkgY29weSBpbm5lciBtYXAncyBzcGluX2xv Y2tfb2ZmDQo+Pj4+IHZhbHVlIHRvIGlubmVyX21hcF9tZXRhLT5zcGluX2xvY2tfb2ZmLg0KPj4+ Pg0KPj4+PiBGaXhlczogZDgzNTI1Y2E2MmNmICgiYnBmOiBpbnRyb2R1Y2UgYnBmX3NwaW5fbG9j ayIpDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFlvbmdob25nIFNvbmcgPHloc0BmYi5jb20+DQo+IA0K PiBBY2tlZC1ieTogQW5kcmlpIE5ha3J5aWtvIDxhbmRyaWluQGZiLmNvbT4NCj4gDQo+Pj4+IC0t LQ0KPj4+PiAgICBrZXJuZWwvYnBmL21hcF9pbl9tYXAuYyB8IDEgKw0KPj4+PiAgICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4+Pj4NCj4+Pj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9i cGYvbWFwX2luX21hcC5jIGIva2VybmVsL2JwZi9tYXBfaW5fbWFwLmMNCj4+Pj4gaW5kZXggNTgz MzQ2YTBhYjI5Li4zZGZmNDE0MDM1ODMgMTAwNjQ0DQo+Pj4+IC0tLSBhL2tlcm5lbC9icGYvbWFw X2luX21hcC5jDQo+Pj4+ICsrKyBiL2tlcm5lbC9icGYvbWFwX2luX21hcC5jDQo+Pj4+IEBAIC01 OCw2ICs1OCw3IEBAIHN0cnVjdCBicGZfbWFwICpicGZfbWFwX21ldGFfYWxsb2MoaW50IGlubmVy X21hcF91ZmQpDQo+Pj4+ICAgICAgICAgICBpbm5lcl9tYXBfbWV0YS0+dmFsdWVfc2l6ZSA9IGlu bmVyX21hcC0+dmFsdWVfc2l6ZTsNCj4+Pj4gICAgICAgICAgIGlubmVyX21hcF9tZXRhLT5tYXBf ZmxhZ3MgPSBpbm5lcl9tYXAtPm1hcF9mbGFnczsNCj4+Pj4gICAgICAgICAgIGlubmVyX21hcF9t ZXRhLT5tYXhfZW50cmllcyA9IGlubmVyX21hcC0+bWF4X2VudHJpZXM7DQo+Pj4+ICsgICAgICAg aW5uZXJfbWFwX21ldGEtPnNwaW5fbG9ja19vZmYgPSBpbm5lcl9tYXAtPnNwaW5fbG9ja19vZmY7 DQo+Pj4NCj4+PiBMb29rcyBsaWtlIHNwaW5sb2NrIGluc2lkZSBpbm5lciBtYXAgaXMgbm90IHN1 cHBvcnRlZDogdGhlcmUgaXMNCj4+PiBzcGVjaWZpYyBjaGVjayBmZXcgbGluZXMgYWJvdmUgcmV0 dXJuaW5nIC1FTk9TVVBQIGZvciBzdWNoIGNhc2UuIEluDQo+Pj4gdGhhdCBjYXNlLCBtYXliZSBh c3NpZ24gLTEgaGVyZSB0byBtYWtlIHRoaXMgZXhwbGljaXQ/DQo+Pg0KPj4gLTEgKC1FUEVSTSkg cHJvYmFibHkgbm90IHRoZSBiZXN0IGNob2ljZS4gVGhlIHZlcmlmaWVyIGFscmVhZHkgaGFzDQo+ PiBrbm93bGVkZ2UgdGhhdCBhIHBhcnRpY3VsYXIgdHJhY2tlZCBtYXAgaXMgYW4gaW5uZXIgbWFw IG9yIG5vdC4gU28NCj4+IGtlZXBpbmcgdGhlIG9yaWdpbmFsIGVycm9yIGNvZGUgKG1vc3RseSAt RUlOVkFMKSBpcyBwcmVmZXJyZWQgSSB0aGluay4NCj4gDQo+IEFoLCBJIGFjdHVhbGx5IG1pc3Nl ZCB0aGUgZmFjdCB0aGF0IHZlcmlmaWVyIGFjdHVhbGx5IGNoZWNrcyB0aG9zZQ0KPiB2YWx1ZXMg KHNvIGl0J3Mgbm90IGp1c3QgPj0gMCBvciA8IDApLCBzbyB5ZWFoLCBsZXQncyBqdXN0IHBhc3MN Cj4gdGhyb3VnaC4gQnR3LCB0aGUgdmFsdWUgd2hlbiB0aGVyZSBpcyBubyBzcGlubG9jayBpcyBh Y3R1YWxseSAtRU5PRU5ULg0KDQpJZiB0aGVyZSBpcyBubyBCVEYsIGl0IHdpbGwgYmUgLUVJTlZB TC4gSWYgdGhlcmUgaXMgQlRGIGFuZCBubyBzcGlubG9jayANCm1lbWJlciwgbW9zdGx5IC1FTk9F TlQuDQoNCj4gDQo+Pg0KPj4+DQo+Pj4gVGhvdWdoIEkgZ3Vlc3MgdGhhdCBhbHNvIGJyaW5ncyB1 cCB0aGUgcXVlc3Rpb246IGlzIHRoZXJlIGFueSBoYXJtIGluDQo+Pj4gc3VwcG9ydGluZyBzcGlu IGxvY2sgZm9yIGlubmVyIG1hcCBhbmQgd2h5IGl0IHdhcyBkaXNhYmxlZCBpbiB0aGUNCj4+PiBm aXJzdCBwbGFjZT8NCj4+DQo+PiBOb3QgZXhhY3RseSBzdXJlIGFib3V0IHRoZSByZWFzb24uIE1h eWJlIHdpdGggdGhpcyBwYXRjaCwgaXQgY2FuIGdldA0KPj4gcHJvcGVyIHN1cHBvcnQuIE5vdCAx MDAlIHN1cmUuDQo+IA0KPiBObywgaXQgd29uJ3QsIGJlY2F1c2UgYnBmX21hcF9tZXRhX2FsbG9j IGV4cGxpY2l0bHkgdGVzdHMgZm9yIGl0Og0KPiANCj4gICAgICAgICAgaWYgKG1hcF92YWx1ZV9o YXNfc3Bpbl9sb2NrKGlubmVyX21hcCkpIHsNCj4gICAgICAgICAgICAgICAgICBmZHB1dChmKTsN Cj4gICAgICAgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRU5PVFNVUFApOw0KPiAgICAgICAg ICB9DQoNCkkgbWVhbiB0aGF0IHRoaXMgY2FuIGJlIHJlbW92ZWQgYWZ0ZXIgbXkgcGF0Y2ggYW5k IGl0IG1heSB3b3JrIDotKQ0KDQo+IA0KPiBNYXliZSBBbGV4ZWkgY2FuIGNsYXJpZnk/DQo+IA0K PiANCj4+DQo+Pj4NCj4+Pj4NCj4+Pj4gICAgICAgICAgIC8qIE1pc2MgbWVtYmVycyBub3QgbmVl ZGVkIGluIGJwZl9tYXBfbWV0YV9lcXVhbCgpIGNoZWNrLiAqLw0KPj4+PiAgICAgICAgICAgaW5u ZXJfbWFwX21ldGEtPm9wcyA9IGlubmVyX21hcC0+b3BzOw0KPj4+PiAtLQ0KPj4+PiAyLjE3LjEN Cj4+Pj4NCg==