From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH nvme-cli v2 15/14] nvme: Add TCP transport Date: Tue, 20 Nov 2018 10:36:42 +0100 Message-ID: References: <20181120030019.31738-1-sagi@grimberg.me> <20181120030019.31738-17-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-block@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Keith Busch , Christoph Hellwig To: Sagi Grimberg , linux-nvme@lists.infradead.org Return-path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:34695 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbeKTUE4 (ORCPT ); Tue, 20 Nov 2018 15:04:56 -0500 Received: by mail-wr1-f65.google.com with SMTP id j2so1198340wrw.1 for ; Tue, 20 Nov 2018 01:36:44 -0800 (PST) In-Reply-To: <20181120030019.31738-17-sagi@grimberg.me> Sender: netdev-owner@vger.kernel.org List-ID: On 11/20/2018 4:00 AM, Sagi Grimberg wrote: > From: Sagi Grimberg > > Signed-off-by: Sagi Grimberg > --- > fabrics.c | 5 ++++- > linux/nvme.h | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fabrics.c b/fabrics.c > index be6a18cd4787..b4fac97253ba 100644 > --- a/fabrics.c > +++ b/fabrics.c > @@ -96,6 +96,7 @@ static const char *arg_str(const char * const *strings, > static const char * const trtypes[] = { > [NVMF_TRTYPE_RDMA] = "rdma", > [NVMF_TRTYPE_FC] = "fibre-channel", > + [NVMF_TRTYPE_TCP] = "tcp", > [NVMF_TRTYPE_LOOP] = "loop", > }; > > @@ -703,11 +704,13 @@ retry: > /* we can safely ignore the rest of the entries */ > break; > case NVMF_TRTYPE_RDMA: > + case NVMF_TRTYPE_TCP: > switch (e->adrfam) { > case NVMF_ADDR_FAMILY_IP4: > case NVMF_ADDR_FAMILY_IP6: > /* FALLTHRU */ > - len = sprintf(p, ",transport=rdma"); > + len = sprintf(p, ",transport=%s", > + e->trtype == NVMF_TRTYPE_RDMA ? "rdma" : "tcp"); So why not just use the trtypes array above? Regards, Arend