From: Paolo Abeni <pabeni@redhat.com>
To: Mina Almasry <almasrymina@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Kaiyuan Zhang <kaiyuanz@google.com>,
Willem de Bruijn <willemb@google.com>,
Eric Dumazet <edumazet@google.com>,
Zoltan Kiss <zoltan.kiss@citrix.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Simon Horman <horms@kernel.org>, Jason Xing <kerneljasonxing@gmail.com>
Subject: Re: [PATCH net v1 2/2] net: core: fix head-page leak in skb_zerocopy
Date: Tue, 25 Aug 2026 11:25:11 +0200 [thread overview]
Message-ID: <e0a9ba12-dcbb-4266-bf1f-1e69b3e51b38@redhat.com> (raw)
In-Reply-To: <20260823183602.1051453-2-almasrymina@google.com>
On 8/23/26 8:36 PM, Mina Almasry wrote:
> When skb_orphan_frags() throws -ENOMEM, skb_copy_ubufs() may have
> already reallocated and replaced 'from->head'. Accessing from->head to
> drop the old refcount leaks the original head page, and erroneously
> puts an unrelated new buffer. Use the local 'page' tracker variable
> instead to drop the reference properly.
>
> Fixes: 36d5fe6a0007 ("core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors")
>
> Signed-off-by: Mina Almasry <almasrymina@google.com>
Note that there must be no empty lines in the tag area; no need to
repost, I'll fix it while applying.
/P
next prev parent reply other threads:[~2026-08-25 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 18:36 [PATCH net v1 1/2] net: core: check skb_frags_readable before uncloning in skb_copy_ubufs Mina Almasry
2026-08-23 18:36 ` [PATCH net v1 2/2] net: core: fix head-page leak in skb_zerocopy Mina Almasry
2026-08-25 9:25 ` Paolo Abeni [this message]
2026-08-25 9:50 ` [PATCH net v1 1/2] net: core: check skb_frags_readable before uncloning in skb_copy_ubufs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a9ba12-dcbb-4266-bf1f-1e69b3e51b38@redhat.com \
--to=pabeni@redhat.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaiyuanz@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox