From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] net: ipv6/gre: Add GRO support
Date: Mon, 2 Apr 2018 07:42:39 -0700
Message-ID: <e0b35a89-2642-d83e-2704-0a76804acb34@gmail.com>
References: <1522588651-28800-1-git-send-email-tariqt@mellanox.com>
 <8dd7220e-e536-f89b-e5d4-27e57f319e0f@gmail.com>
 <CAKHjkjkk4ktJbh+3NJvS+PF+V1ZCKGE8ACfrOj0SE19m3-1oeA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Tariq Toukan <tariqt@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>,
        Linux Netdev List <netdev@vger.kernel.org>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Eric Dumazet <edumazet@google.com>
To: Eran Ben Elisha <eranlinuxmellanox@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:44659 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752248AbeDBOmm (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 2 Apr 2018 10:42:42 -0400
Received: by mail-pl0-f65.google.com with SMTP id b6-v6so2387748pla.11
        for <netdev@vger.kernel.org>; Mon, 02 Apr 2018 07:42:41 -0700 (PDT)
In-Reply-To: <CAKHjkjkk4ktJbh+3NJvS+PF+V1ZCKGE8ACfrOj0SE19m3-1oeA@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 04/02/2018 05:40 AM, Eran Ben Elisha wrote:
> On Sun, Apr 1, 2018 at 7:35 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>
>>
>> On 04/01/2018 06:17 AM, Tariq Toukan wrote:
>>> From: Eran Ben Elisha <eranbe@mellanox.com>
>>>
>>> Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells
>>> infrastructure.
>>>
>>> Performance testing: 55% higher badwidth.
>>> Measuring bandwidth of 1 thread IPv4 TCP traffic over IPv6 GRE tunnel
>>> while GRO on the physical interface is disabled.
>>> CPU: Intel Xeon E312xx (Sandy Bridge)
>>> NIC: Mellanox Technologies MT27700 Family [ConnectX-4]
>>> Before (GRO not working in tunnel) : 2.47 Gbits/sec
>>> After  (GRO working in tunnel)     : 3.85 Gbits/sec
>>>
>>> Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
>>> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
>>> CC: Eric Dumazet <edumazet@google.com>
>>> ---
>>
>>
>> Seems good, but why isn't this handled directly in GRO native layer ?
> ip6_tunnel and ip6_gre do not share initialization flow functions (unlike ipv4).
> Changing the ipv6 init infrastructure should not be part of this
> patch. we prefer to keep this one minimal, simple and safe.



Looking at gre_gro_receive() and gre_gro_complete() I could not see why they
could not be copied/pasted to IPv6.

Maybe give more details on the changelog, it is really not obvious.