From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED81C11F67 for ; Tue, 29 Jun 2021 19:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53CB361D3E for ; Tue, 29 Jun 2021 19:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235459AbhF2TOB (ORCPT ); Tue, 29 Jun 2021 15:14:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25271 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233916AbhF2TOA (ORCPT ); Tue, 29 Jun 2021 15:14:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624993892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQbKJDDcSDig+ZoAeWjxtVythqP5H1mHSwjXk0i1+DA=; b=cgOKIyvytVibtn96Mz00EQFk/XsBio9T8ZsDYiayc/9P2ZQEPOQF7K6D6xBB7XLRqx4Fbi LYT58ngSuv8e/AOeTGjtIT1CK96DfTwz9CVrw29algc6ZMAdlMq+U3cMunCTVrtt05RQsW FysRP0zt0wK8HQWF4pZVoOTxUXsCvco= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-bzfWpom-M4KgESoPWVGJNA-1; Tue, 29 Jun 2021 15:11:31 -0400 X-MC-Unique: bzfWpom-M4KgESoPWVGJNA-1 Received: by mail-ej1-f70.google.com with SMTP id p5-20020a17090653c5b02903db1cfa514dso6092098ejo.13 for ; Tue, 29 Jun 2021 12:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=hQbKJDDcSDig+ZoAeWjxtVythqP5H1mHSwjXk0i1+DA=; b=WTEyte4kuHeo3xNMsrMJUjT8Dj7RHleFSVRBzPDT6ZLMIQcw1mo4laKZp4wABaDyP/ IXTemDrfYnCxQlAr7GQoKjzB+rZmUAXJAwVGU71BEwk59vs4/IghOT5JINQnhG93zaE3 jpqKRFAOWdsE+NYmKibSTZ9g/xmTadAAZasPoZ0/SmKQehqZhC0rsZWos/+HD+iGKc8w bJz6CjBC9HEHykxedSZJSv/b1oBpSRKs+EGq2ICU3EDOyC7Xf/pawqXww0RjVCDFrpf4 8k7hQvvrMhIOYEzCDGjZZu2vngDEvQPg6zJOOhopVjZwnTk6yxngJES8Q793cly0RvJN wQVQ== X-Gm-Message-State: AOAM530vM+0n97/ErHxPGUhpWHhbHxpQD4GQgBQTnOLyZFGaYzieHwDI A/Aa1QcFxwmlaektomJ7TESMso6grvQ6tv+puYbXvRPJ0VWfaKIF+9GxkcnnfquCMgmv0xOFp9e BMVRnEvdMWL8XnEXd X-Received: by 2002:aa7:cb90:: with SMTP id r16mr42469797edt.121.1624993889968; Tue, 29 Jun 2021 12:11:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYfiAdRV7D9nbJlFYuLhJYgtRi1/mP11UguePTeWSxfBXzg7z7ozLYXvwGM8BWUH2BqP+sHA== X-Received: by 2002:aa7:cb90:: with SMTP id r16mr42469769edt.121.1624993889846; Tue, 29 Jun 2021 12:11:29 -0700 (PDT) Received: from [192.168.42.238] (3-14-107-185.static.kviknet.dk. [185.107.14.3]) by smtp.gmail.com with ESMTPSA id n4sm8519460eja.121.2021.06.29.12.11.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jun 2021 12:11:29 -0700 (PDT) Subject: Re: [PATCH v9 bpf-next 01/14] net: skbuff: add data_len field to skb_shared_info To: Jakub Kicinski , Alexander Duyck Cc: Lorenzo Bianconi , Lorenzo Bianconi , bpf , Netdev , David Miller , Alexei Starovoitov , Daniel Borkmann , shayagr@amazon.com, "Jubran, Samih" , John Fastabend , David Ahern , Jesper Dangaard Brouer , Eelco Chaudron , Jason Wang , Saeed Mahameed , Maciej Fijalkowski , "Karlsson, Magnus" , Tirthendu References: <8ad0d38259a678fb42245368f974f1a5cf47d68d.1623674025.git.lorenzo@kernel.org> <20210629100852.56d995a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210629113714.6d8e2445@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Jesper Dangaard Brouer Message-ID: Date: Tue, 29 Jun 2021 21:11:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210629113714.6d8e2445@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 29/06/2021 20.37, Jakub Kicinski wrote: > On Tue, 29 Jun 2021 11:18:38 -0700 Alexander Duyck wrote: >> On Tue, Jun 29, 2021 at 10:08 AM Jakub Kicinski wrote: >>>> ack, I agree. I will fix it in v10. >>> Why is XDP mb incompatible with LRO? I thought that was one of the use >>> cases (mentioned by Willem IIRC). >> XDP is meant to be a per packet operation with support for TX and >> REDIRECT, and LRO isn't routable. So we could put together a large LRO >> frame but we wouldn't be able to break it apart again. If we allow >> that then we are going to need a ton more exception handling added to >> the XDP paths. >> >> As far as GSO it would require setting many more fields in order to >> actually make it offloadable by any hardware. > It would require more work, but TSO seems to be explicitly stated > as what the series builds towards (in the cover letter). It's fine > to make choices we'd need to redo later, I guess, I'm just trying > to understand the why. This is also my understanding that LRO and TSO is what this patchset is working towards. Sorry, I don't agree or understand this requested change.