From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port TC2QOS mapping Date: Sat, 2 Sep 2017 09:32:08 -0700 Message-ID: References: <1504310354-42773-1-git-send-email-f.fainelli@gmail.com> <1504310354-42773-5-git-send-email-f.fainelli@gmail.com> <20170902163057.GB5463@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, vivien.didelot@savoirfairelinux.com, jiri@resnulli.us, jhs@mojatatu.com, xiyou.wangcong@gmail.com To: Andrew Lunn Return-path: Received: from mail-oi0-f47.google.com ([209.85.218.47]:34771 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752702AbdIBQcL (ORCPT ); Sat, 2 Sep 2017 12:32:11 -0400 Received: by mail-oi0-f47.google.com with SMTP id w10so20902136oie.1 for ; Sat, 02 Sep 2017 09:32:11 -0700 (PDT) In-Reply-To: <20170902163057.GB5463@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/02/2017 09:30 AM, Andrew Lunn wrote: >> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port) >> reg |= MII_DUMB_FWDG_EN; >> core_writel(priv, reg, CORE_SWITCH_CTRL); >> >> + /* Configure Traffic Class to QoS mapping, allow each priority to map >> + * to a different queue number >> + */ >> + reg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port)); >> + for (i = 0; i < 8; i++) >> + reg |= i << (PRT_TO_QID_SHIFT * i); > > Hi Florian > > Rather than 8, would ds->num_tx_queues be more descriptive? I actually have a patch on top of this which defines a constant for the number of queues instead of open coding 8 here. Thanks! -- Florian