From: David Ahern <dsahern@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Daniele Palmas <dnlplm@gmail.com>, Alex Elder <elder@linaro.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS
Date: Mon, 27 Sep 2021 07:48:54 -0600 [thread overview]
Message-ID: <e0da1be9-e3d4-f718-e2c6-e18cda5b3269@gmail.com> (raw)
In-Reply-To: <20210924033351.2878153-1-bjorn.andersson@linaro.org>
On 9/23/21 9:33 PM, Bjorn Andersson wrote:
> diff --git a/ip/iplink_rmnet.c b/ip/iplink_rmnet.c
> index 1d16440c6900..f629ca9976d9 100644
> --- a/ip/iplink_rmnet.c
> +++ b/ip/iplink_rmnet.c
> @@ -16,6 +16,12 @@ static void print_explain(FILE *f)
> {
> fprintf(f,
> "Usage: ... rmnet mux_id MUXID\n"
> + " [ingress-deaggregation { on | off } ]\n"
> + " [ingress-commands { on | off } ]\n"
> + " [ingress-chksumv4 { on | off } ]\n"
> + " [ingress-chksumv5 { on | off } ]\n"
> + " [egress-chksumv4 { on | off } ]\n"
> + " [egress-chksumv5 { on | off } ]\n"
> "\n"
> "MUXID := 1-254\n"
> );
> @@ -26,9 +32,16 @@ static void explain(void)
> print_explain(stderr);
> }
>
> +static int on_off(const char *msg, const char *arg)
> +{
> + fprintf(stderr, "Error: argument of \"%s\" must be \"on\" or \"off\", not \"%s\"\n", msg, arg);
> + return -1;
> +}
> +
> static int rmnet_parse_opt(struct link_util *lu, int argc, char **argv,
> struct nlmsghdr *n)
> {
> + struct ifla_rmnet_flags flags = { };
> __u16 mux_id;
>
> while (argc > 0) {
> @@ -37,6 +50,60 @@ static int rmnet_parse_opt(struct link_util *lu, int argc, char **argv,
> if (get_u16(&mux_id, *argv, 0))
> invarg("mux_id is invalid", *argv);
> addattr16(n, 1024, IFLA_RMNET_MUX_ID, mux_id);
> + } else if (matches(*argv, "ingress-deaggregation") == 0) {
> + NEXT_ARG();
> + flags.mask |= RMNET_FLAGS_INGRESS_DEAGGREGATION;
> + if (strcmp(*argv, "on") == 0)
> + flags.flags |= RMNET_FLAGS_INGRESS_DEAGGREGATION;
> + else if (strcmp(*argv, "off") == 0)
> + flags.flags &= ~RMNET_FLAGS_INGRESS_DEAGGREGATION;
> + else
> + return on_off("ingress-deaggregation", *argv);
> + } else if (matches(*argv, "ingress-commands") == 0) {
> + NEXT_ARG();
> + flags.mask |= RMNET_FLAGS_INGRESS_MAP_COMMANDS;
> + if (strcmp(*argv, "on") == 0)
> + flags.flags |= RMNET_FLAGS_INGRESS_MAP_COMMANDS;
> + else if (strcmp(*argv, "off") == 0)
> + flags.flags &= ~RMNET_FLAGS_INGRESS_MAP_COMMANDS;
> + else
> + return on_off("ingress-commands", *argv);
> + } else if (matches(*argv, "ingress-chksumv4") == 0) {
> + NEXT_ARG();
> + flags.mask |= RMNET_FLAGS_INGRESS_MAP_CKSUMV4;
> + if (strcmp(*argv, "on") == 0)
> + flags.flags |= RMNET_FLAGS_INGRESS_MAP_CKSUMV4;
> + else if (strcmp(*argv, "off") == 0)
> + flags.flags &= ~RMNET_FLAGS_INGRESS_MAP_CKSUMV4;
> + else
> + return on_off("ingress-chksumv4", *argv);
> + } else if (matches(*argv, "ingress-chksumv5") == 0) {
> + NEXT_ARG();
> + flags.mask |= RMNET_FLAGS_INGRESS_MAP_CKSUMV5;
> + if (strcmp(*argv, "on") == 0)
> + flags.flags |= RMNET_FLAGS_INGRESS_MAP_CKSUMV5;
> + else if (strcmp(*argv, "off") == 0)
> + flags.flags &= ~RMNET_FLAGS_INGRESS_MAP_CKSUMV5;
> + else
> + return on_off("ingress-chksumv5", *argv);
> + } else if (matches(*argv, "egress-chksumv4") == 0) {
> + NEXT_ARG();
> + flags.mask |= RMNET_FLAGS_EGRESS_MAP_CKSUMV4;
> + if (strcmp(*argv, "on") == 0)
> + flags.flags |= RMNET_FLAGS_EGRESS_MAP_CKSUMV4;
> + else if (strcmp(*argv, "off") == 0)
> + flags.flags &= ~RMNET_FLAGS_EGRESS_MAP_CKSUMV4;
> + else
> + return on_off("egress-chksumv4", *argv);
> + } else if (matches(*argv, "egress-chksumv5") == 0) {
> + NEXT_ARG();
> + flags.mask |= RMNET_FLAGS_EGRESS_MAP_CKSUMV5;
> + if (strcmp(*argv, "on") == 0)
> + flags.flags |= RMNET_FLAGS_EGRESS_MAP_CKSUMV5;
> + else if (strcmp(*argv, "off") == 0)
> + flags.flags &= ~RMNET_FLAGS_EGRESS_MAP_CKSUMV5;
> + else
> + return on_off("egress-chksumv5", *argv);
> } else if (matches(*argv, "help") == 0) {
> explain();
> return -1;
use strcmp for new options. Also, please use 'csum' instead of 'chksum'
in the names. csum is already widely used in ip commands.
next prev parent reply other threads:[~2021-09-27 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 3:33 [PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS Bjorn Andersson
2021-09-27 13:48 ` David Ahern [this message]
2021-09-27 22:44 ` Alex Elder
2021-09-28 2:09 ` David Ahern
2021-09-27 22:44 ` Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2021-03-15 15:46 Bjorn Andersson
2021-03-15 16:16 ` Alex Elder
2021-04-02 17:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0da1be9-e3d4-f718-e2c6-e18cda5b3269@gmail.com \
--to=dsahern@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=dnlplm@gmail.com \
--cc=elder@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).