From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claudiu Beznea <Claudiu.Beznea@microchip.com>
Subject: Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs
 computation
Date: Thu, 19 Jul 2018 10:03:24 +0300
Message-ID: <e0e0257c-542d-30af-ec40-1293758ae6a5@microchip.com>
References: <1531918689-22658-1-git-send-email-claudiu.beznea@microchip.com>
 <1531918689-22658-4-git-send-email-claudiu.beznea@microchip.com>
 <20180719.025423.1409264262161292298.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: <nicolas.ferre@microchip.com>, <netdev@vger.kernel.org>,
        <jennifer.dahm@ni.com>, <nathan.sullivan@ni.com>
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from esa1.microchip.iphmx.com ([68.232.147.91]:59965 "EHLO
        esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726931AbeGSHpG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Jul 2018 03:45:06 -0400
In-Reply-To: <20180719.025423.1409264262161292298.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 18.07.2018 20:54, David Miller wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
> Date: Wed, 18 Jul 2018 15:58:09 +0300
> 
>>  
>> +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
>> +{
>> +	struct sk_buff *nskb;
>> +	int padlen = ETH_ZLEN - (*skb)->len;
>> +	int headroom = skb_headroom(*skb);
>> +	int tailroom = skb_tailroom(*skb);
>> +	bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb);
>> +	u32 fcs;
> 
> Please keep local variable ordered from longest to shortest line
> (ie. reverse christmas tree format).

OK! Thank you!

> 
> Thank you.
>