* [PATCH net-next] tools: ynl-gen: add missing empty line between policies
@ 2023-08-08 20:09 Jakub Kicinski
2023-08-08 20:50 ` Vadim Fedorenko
2023-08-09 20:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-08-08 20:09 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski, vadim.fedorenko
We're missing empty line between policies.
DPLL will need this.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: vadim.fedorenko@linux.dev
---
tools/net/ynl/ynl-gen-c.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py
index e64311331726..85cf159d3074 100755
--- a/tools/net/ynl/ynl-gen-c.py
+++ b/tools/net/ynl/ynl-gen-c.py
@@ -1871,6 +1871,7 @@ _C_KW = {
for _, arg in struct.member_list():
arg.attr_policy(cw)
cw.p("};")
+ cw.nl()
def kernel_can_gen_family_struct(family):
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] tools: ynl-gen: add missing empty line between policies
2023-08-08 20:09 [PATCH net-next] tools: ynl-gen: add missing empty line between policies Jakub Kicinski
@ 2023-08-08 20:50 ` Vadim Fedorenko
2023-08-09 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2023-08-08 20:50 UTC (permalink / raw)
To: Jakub Kicinski, davem; +Cc: netdev, edumazet, pabeni
On 08/08/2023 21:09, Jakub Kicinski wrote:
> We're missing empty line between policies.
> DPLL will need this.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Yep, now it works perfect.
Tested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tools: ynl-gen: add missing empty line between policies
2023-08-08 20:09 [PATCH net-next] tools: ynl-gen: add missing empty line between policies Jakub Kicinski
2023-08-08 20:50 ` Vadim Fedorenko
@ 2023-08-09 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-09 20:20 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, vadim.fedorenko
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 8 Aug 2023 13:09:07 -0700 you wrote:
> We're missing empty line between policies.
> DPLL will need this.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: vadim.fedorenko@linux.dev
>
> [...]
Here is the summary with links:
- [net-next] tools: ynl-gen: add missing empty line between policies
https://git.kernel.org/netdev/net-next/c/cd3112ebbaf4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-09 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 20:09 [PATCH net-next] tools: ynl-gen: add missing empty line between policies Jakub Kicinski
2023-08-08 20:50 ` Vadim Fedorenko
2023-08-09 20:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).