From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append Date: Tue, 3 Jul 2018 14:02:06 -0600 Message-ID: References: <20180702220312.14590-1-dsahern@kernel.org> <20180703134302.GB15120@splinter.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sharpd@cumulusnetworks.com, Thomas.Winter@alliedtelesis.co.nz, petrm@mellanox.com To: Ido Schimmel , dsahern@kernel.org Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:45532 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753052AbeGCUCK (ORCPT ); Tue, 3 Jul 2018 16:02:10 -0400 Received: by mail-pf0-f193.google.com with SMTP id y24-v6so1501971pfe.12 for ; Tue, 03 Jul 2018 13:02:09 -0700 (PDT) In-Reply-To: <20180703134302.GB15120@splinter.mtl.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 7/3/18 7:43 AM, Ido Schimmel wrote: > On Mon, Jul 02, 2018 at 03:03:12PM -0700, dsahern@kernel.org wrote: >> From: David Ahern >> >> NetworkManager likes to manage linklocal prefix routes and does so with >> the NLM_F_APPEND flag, breaking attempts to simplify the IPv6 route >> code and by extension enable multipath routes with device only nexthops. >> >> Revert f34436a43092 and its followup >> 6eba08c3626b ("ipv6: Only emit append events for appended routes"). >> Update the test cases to reflect the old behavior. >> >> Fixes: f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route") >> Signed-off-by: David Ahern >> --- >> Ido: I left 5a15a1b07c51. FIB_EVENT_ENTRY_APPEND is not generated for >> IPv6, so no harm in leaving it. > > OK, but I had a follow-up series that did further changes in mlxsw > (merge commit eab9a2d5f323) to support the new behavior. You want to > revert it and squash to v2 or I'll send another revert? I'll squash. The ability to add dev only nexthops is clearly needed. Reverting in 1 patch will help on the next attempt. It is unfortunate that mlxsw has to replicate the node lookup code. > > Also, Petr added a multipath test that relies on IPv6 device only > nexthops. See commit 54818c4c4b937. > ok. I'll remove the ipv6 mpath tests as well.