From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6FDC43381 for ; Mon, 18 Feb 2019 19:37:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D15242177E for ; Mon, 18 Feb 2019 19:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbfBRThN (ORCPT ); Mon, 18 Feb 2019 14:37:13 -0500 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:55284 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726941AbfBRThN (ORCPT ); Mon, 18 Feb 2019 14:37:13 -0500 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 01539980078; Mon, 18 Feb 2019 19:37:11 +0000 (UTC) Received: from ec-desktop.uk.solarflarecom.com (10.17.20.45) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 18 Feb 2019 11:37:07 -0800 Subject: Re: TC stats / hw offload question From: Edward Cree To: Jamal Hadi Salim , netdev CC: Jiri Pirko , Cong Wang , "Or Gerlitz" , Andy Gospodarek , "PJ Waskiewicz" , Anjali Singhai Jain , Jakub Kicinski References: <26f0cfc9-3bef-8579-72cc-aa6c5ccecd43@solarflare.com> <4cb765dd-453f-3139-bce6-6e0b31167aec@mojatatu.com> <70d77198-42fd-838a-d352-2647e7cad4d6@solarflare.com> <561205a6-101b-c86b-e77d-6ebdcf31a56d@mojatatu.com> <11ab2dc0-ec39-18cd-d170-0d5f954198b9@solarflare.com> <702dd5b7-c6ed-b669-8270-d44f5ff4fb30@mojatatu.com> <5930f8e7-3615-5470-ea09-f0e6f2a3a3d7@solarflare.com> Message-ID: Date: Mon, 18 Feb 2019 19:37:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5930f8e7-3615-5470-ea09-f0e6f2a3a3d7@solarflare.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [10.17.20.45] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24436.000 X-TM-AS-Result: No-3.560200-4.000000-10 X-TMASE-MatchedRID: fgYTp5XatxYOwH4pD14DsPHkpkyUphL9QfvCwHnjjjDb6Y+fnTZUL+rf 1qcmViGylC/T5q8XR1vWG/9HApwCL7DMW7LJrZawwCZxkTHxcclMjQ19j30wyZsoi2XrUn/JxbG vmM9nj5NQSFbL1bvQAcK21zBg2KlfT2FZqUzXVBpitD4ZPiuWmSAoWZQSSbsjW6Jp8nFaQs1ww5 eklwEGQflxgh8SjvHz1A00bt0Mj5TmlBPL3aqjIWvQkXg+fRFm6Ncbn0oyKd0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.560200-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24436.000 X-MDID: 1550518632-bvr1mumEg8gC Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/02/19 18:56, Edward Cree wrote: > (or >  maybe require it to be set to some distinguished value, like 0, to >  mean 'allocate', so that as a future extension we can support >  shareable counters). Turns out 0 isn't an option, because TC already internally swallows  that and allocates its own index (same as if 'index' wasn't specified  on cmdline at all), unless we can change TC to pass that 0 on to the  driver. -Ed