netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hau <hau@realtek.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Anthony Wong <anthony.wong@canonical.com>,
	Jason Yen <jason.yen@canonical.com>
Subject: RE: SFP+ support for 8168fp/8117
Date: Wed, 4 Mar 2020 15:24:48 +0000	[thread overview]
Message-ID: <e10eef58d8fc4b67ac2a73784bf86381@realtek.com> (raw)
In-Reply-To: <5A21808E-C9DA-44BF-952B-4A5077B52E9B@canonical.com>

> Hi Hau,
> 
> > On Feb 19, 2020, at 22:48, Kai-Heng Feng <kai.heng.feng@canonical.com>
> wrote:
> >
> > Hi Hau,
> >
> >> On Feb 19, 2020, at 22:22, Hau <hau@realtek.com> wrote:
> >
> > [snipped]
> >
> >>
> >> Hi Kai-Heng,
> >>
> >> Attached file is r8168 that I have add SFP+ support for rtl8168fp. If
> possible, please give it a try.
> >
> > I've already tested r8168 and it does support SFP+.
> >
> > What we are discussing here is to support this chip properly in mainline
> kernel.
> >
> > This is what we've discussed so far:
> > https://lore.kernel.org/lkml/2D8F5FFE-3EC3-480B-9D15-
> 23CACE5556DF@canonical.com/
> 
> Is there anything you can share so we can support this chip properly in
> upstream?
> 

Hi Kai-Heng,

For adding SFP+ support for rtl8168fp, 
1.Some power saving features must be disabled, like APDLS/EEE/EEEPLUS...
2.PHY capability must be set to auto-negation.

I am kind of busy this week. I will try to add support for this chip into upstream next week.

Thanks,
Hau

> ------Please consider the environment before printing this e-mail.

  reply	other threads:[~2020-03-04 15:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  6:59 SFP+ support for 8168fp/8117 Kai Heng Feng
2020-01-02 15:21 ` Andrew Lunn
2020-01-02 16:46   ` Kai-Heng Feng
2020-01-02 21:24     ` Heiner Kallweit
2020-01-03  4:53       ` Kai-Heng Feng
2020-02-13  6:14         ` Kai-Heng Feng
2020-02-14  9:07           ` Hau
2020-02-17  6:37             ` Kai Heng Feng
2020-02-19 14:22               ` Hau
2020-02-19 14:48                 ` Kai-Heng Feng
2020-02-27  8:49                   ` Kai-Heng Feng
2020-03-04 15:24                     ` Hau [this message]
2020-03-04 15:28                       ` Andrew Lunn
2020-03-05 12:36                         ` Hau
2020-03-06 15:34                         ` Hau
2020-03-06 15:58                           ` Andrew Lunn
2020-03-06 16:33                             ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e10eef58d8fc4b67ac2a73784bf86381@realtek.com \
    --to=hau@realtek.com \
    --cc=andrew@lunn.ch \
    --cc=anthony.wong@canonical.com \
    --cc=hkallweit1@gmail.com \
    --cc=jason.yen@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).