Re: [PATCH v7 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink

[Riana Tauro <riana.tauro@intel.com>]

Hi Jakub

On 2/19/2026 7:26 AM, Jakub Kicinski wrote:
> On Wed, 18 Feb 2026 17:49:03 +0530 Riana Tauro wrote:
>> +    -
>> +      name: get-error-counters
>> +      doc: >-
>> +           Retrieve the full list of error counters for a given node.
>> +           The response include the id, the name, and even the current
>> +           value of each counter.
>> +      attribute-set: error-counter-attrs
>> +      flags: [admin-perm]
>> +      dump:
>> +        request:
>> +          attributes:
>> +            - node-id
>> +        reply:
>> +          attributes:
>> +            - error-id
>> +            - error-name
>> +            - error-value
>> +    -
>> +      name: query-error-counter
>> +      doc: >-
>> +           Query the information of a specific error counter for a given node.
>> +           Users must provide the node ID and the error counter ID.
>> +           The response contains the id, the name, and the current value
>> +           of the counter.
>> +      attribute-set: error-counter-attrs
>> +      flags: [admin-perm]
>> +      do:
>> +        request:
>> +          attributes:
>> +            - node-id
>> +            - error-id
>> +        reply:
>> +          attributes:
>> +            - error-id
>> +            - error-name
>> +            - error-value
> 
> The get-error-counters vs query-error-counter is sort of asking to be a
> do and dump of the same op doesn't it? The return messages are the same,
> one returns a single counter, the other one (filtered to given node-id)
> dump of counters. Not a big deal, but from Netlink perspective having
> these as do / dump of the same op would be more natural.

Yeah they have the same responses. I looked at the other yaml files and 
yeah it would be cleaner to use the same op to make it more consistent.

Thank you for the suggestion. I will add the change in the next rev.

> 
> On top of that please definitely make sure that the code is generated
> with the latest tooling from Linus's tree! We tweaked the output a
> little, it shouldn't happen again but running regen with this commit
> gives me a dirty tree with a bunch of:

I did generate it for initial revisions, but then kept the same files in
the latest revisions since there were no changes. Sorry will regenerate 
and send it.

> 
> diff --git a/include/uapi/drm/drm_ras.h b/include/uapi/drm/drm_ras.h
> index 3415ba345ac8..31f0180c1035 100644
> --- a/include/uapi/drm/drm_ras.h
> +++ b/include/uapi/drm/drm_ras.h
> @@ -2,6 +2,7 @@
>   /* Do not edit directly, auto-generated from: */
>   /*     Documentation/netlink/specs/drm_ras.yaml */
>   /* YNL-GEN uapi header */
> +/* To regenerate run: tools/net/ynl/ynl-regen.sh */
>   
>   #ifndef _UAPI_LINUX_DRM_RAS_H
>   #define _UAPI_LINUX_DRM_RAS_H
> 
> 
> Last but not least:
> 
> $ yamllint Documentation/netlink/specs/drm_ras.yaml
> Documentation/netlink/specs/drm_ras.yaml
>    59:14     error    too many spaces after colon  (colons)

Will fix this

Thank you
Riana

>