netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Junxian Huang <huangjunxian6@hisilicon.com>,
	jgg@ziepe.ca, leon@kernel.org, stephen@networkplumber.org
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linuxarm@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 iproute2-next 2/2] rdma: Add support to dump SRQ resource in raw format
Date: Sun, 15 Oct 2023 21:54:14 -0600	[thread overview]
Message-ID: <e12077e2-ac6e-ae76-bc11-7795034df6c0@gmail.com> (raw)
In-Reply-To: <20231010075526.3860869-3-huangjunxian6@hisilicon.com>

On 10/10/23 1:55 AM, Junxian Huang wrote:
> @@ -162,6 +162,20 @@ out:
>  	return -EINVAL;
>  }
>  
> +static int res_srq_line_raw(struct rd *rd, const char *name, int idx,
> +			    struct nlattr **nla_line)
> +{
> +	if (!nla_line[RDMA_NLDEV_ATTR_RES_RAW])
> +		return MNL_CB_ERROR;
> +
> +	open_json_object(NULL);

open_json_object with no corresponding close.

> +	print_dev(rd, idx, name);
> +	print_raw_data(rd, nla_line);
> +	newline(rd);
> +
> +	return MNL_CB_OK;
> +}
> +
>  static int res_srq_line(struct rd *rd, const char *name, int idx,
>  			struct nlattr **nla_line)
>  {



  parent reply	other threads:[~2023-10-16  3:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  7:55 [PATCH v2 iproute2-next 0/2] rdma: Support dumping SRQ resource in raw format Junxian Huang
2023-10-10  7:55 ` [PATCH v2 iproute2-next 1/2] rdma: Update uapi headers Junxian Huang
2023-10-15  8:14   ` Leon Romanovsky
2023-10-10  7:55 ` [PATCH v2 iproute2-next 2/2] rdma: Add support to dump SRQ resource in raw format Junxian Huang
2023-10-15  8:15   ` Leon Romanovsky
2023-10-16  3:54   ` David Ahern [this message]
2023-10-16  6:31     ` Leon Romanovsky
2023-10-16 16:20 ` [PATCH v2 iproute2-next 0/2] rdma: Support dumping " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e12077e2-ac6e-ae76-bc11-7795034df6c0@gmail.com \
    --to=dsahern@gmail.com \
    --cc=huangjunxian6@hisilicon.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).