From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Fastabend <john.fastabend@gmail.com>
Subject: Re: [RFC PATCH 10/17] net: sched: qdisc_qlen for per cpu logic
Date: Wed, 15 Nov 2017 07:18:43 -0800
Message-ID: <e13547b5-ced5-a606-05a8-4a19294afa4e@gmail.com>
References: <20171113195256.6245.64676.stgit@john-Precision-Tower-5810>
 <20171113201055.6245.8474.stgit@john-Precision-Tower-5810>
 <CAF=yD-KiBQ06vMyshQd4WNXP8S2iRKeWfW10LM116Z=Kd+Va0A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Daniel Borkmann <daniel@iogearbox.net>,
        Eric Dumazet <eric.dumazet@gmail.com>, make0818@gmail.com,
        Network Development <netdev@vger.kernel.org>,
        =?UTF-8?B?SmnFmcOtIFDDrXJr?= =?UTF-8?Q?o?= <jiri@resnulli.us>,
        Cong Wang <xiyou.wangcong@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:56791 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755854AbdKOPTK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 15 Nov 2017 10:19:10 -0500
Received: by mail-pg0-f67.google.com with SMTP id z184so12834370pgd.13
        for <netdev@vger.kernel.org>; Wed, 15 Nov 2017 07:19:09 -0800 (PST)
In-Reply-To: <CAF=yD-KiBQ06vMyshQd4WNXP8S2iRKeWfW10LM116Z=Kd+Va0A@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/14/2017 05:16 PM, Willem de Bruijn wrote:
> On Mon, Nov 13, 2017 at 3:10 PM, John Fastabend
> <john.fastabend@gmail.com> wrote:
>> Add qdisc qlen helper routines for lockless qdiscs to use.
>>
>> The qdisc qlen is no longer used in the hotpath but it is reported
>> via stats query on the qdisc so it still needs to be tracked. This
>> adds the per cpu operations needed.
>>
>> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
>> ---
>>  0 files changed
>>
>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> index 4717c4b..bad24a9 100644
>> --- a/include/net/sch_generic.h
>> +++ b/include/net/sch_generic.h
>> @@ -291,8 +291,16 @@ static inline void qdisc_cb_private_validate(const struct sk_buff *skb, int sz)
>>         BUILD_BUG_ON(sizeof(qcb->data) < sz);
>>  }
>>
>> +static inline int qdisc_qlen_cpu(const struct Qdisc *q)
>> +{
>> +       return this_cpu_ptr(q->cpu_qstats)->qlen;
>> +}
>> +
>>  static inline int qdisc_qlen(const struct Qdisc *q)
>>  {
>> +       if (q->flags & TCQ_F_NOLOCK)
>> +               return qdisc_qlen_cpu(q);
> 
> Shouldn't this return qdisc_qlen_sum from the follow-on patch?
> The two patches can also be squashed.
>
Actually I think this change can just be dropped. Looks like
I removed all cases of calling it from NOLOCK paths.

Also squashing this patch with 11/17 seems reasonable will go ahead
and do that.