From: Andrew Lunn <andrew@lunn.ch>
To: Manuel Ebner <manuelebner@mailbox.org>
Cc: Oliver Neukum <oneukum@suse.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 net-next 1/7] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet
Date: Thu, 9 Jul 2026 15:55:37 +0200 [thread overview]
Message-ID: <e136d383-7593-431e-ad8e-ad85a9af0f8c@lunn.ch> (raw)
In-Reply-To: <0a0721d511c10414cb6a6e53f1bb33698ada963e.camel@mailbox.org>
On Thu, Jul 09, 2026 at 02:37:32PM +0200, Manuel Ebner wrote:
> On Thu, 2026-07-09 at 14:01 +0200, Oliver Neukum wrote:
>
> I guess a couple suggestions got lost, that's ok.
This patch is a pure move code around patch. It is bad practice to
make changes while moving code, since that needs a different sort of
review.
If the comments are to be improved, that should be in a separate
patch.
Andrew
prev parent reply other threads:[~2026-07-09 13:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 12:01 [PATCHv2 net-next 1/7] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet Oliver Neukum
2026-07-09 12:01 ` [PATCHv2 net-next 2/7] net: usb: usbnet: add cdc_state to struct usbnet Oliver Neukum
2026-07-09 13:49 ` Andrew Lunn
2026-07-09 12:01 ` [PATCHv2 net-next 3/7] net: usb: use cdc_state in " Oliver Neukum
2026-07-09 13:49 ` Andrew Lunn
2026-07-09 12:01 ` [PATCHv2 net-next 4/7] net: usb: int51x1: drop dependency on cdc_ether Oliver Neukum
2026-07-09 13:50 ` Andrew Lunn
2026-07-09 12:01 ` [PATCHv2 net-next 5/7] net: usb: move exported symbols from cdc_ether to usbnet Oliver Neukum
2026-07-09 13:51 ` Andrew Lunn
2026-07-09 12:01 ` [PATCHv2 net-next 6/7] net: usb: remove dependencies on cdc_ether Oliver Neukum
2026-07-09 13:52 ` Andrew Lunn
2026-07-09 18:08 ` Sergey Shtylyov
2026-07-09 12:01 ` [PATCHv2 net-next 7/7] net: usb: usbnet: remove outdated sanity check Oliver Neukum
2026-07-09 13:56 ` Andrew Lunn
2026-07-09 12:37 ` [PATCHv2 net-next 1/7] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet Manuel Ebner
2026-07-09 13:55 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e136d383-7593-431e-ad8e-ad85a9af0f8c@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manuelebner@mailbox.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox