From: Heiner Kallweit <hkallweit1@gmail.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 1/8] r8169: add info for DASH being enabled
Date: Wed, 17 Jun 2020 22:51:10 +0200 [thread overview]
Message-ID: <e1385f3c-49d2-35f5-15d4-783cccf80ed5@gmail.com> (raw)
In-Reply-To: <ef2a4cd4-1492-99d8-f94f-319eeb129137@gmail.com>
In case of problems it facilitates the bug analysis if we know whether
DASH is active. Therefore emit a message in probe if this is the case.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index dad84ecf5..7bb26fb07 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5432,8 +5432,10 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
jumbo_max, tp->mac_version <= RTL_GIGA_MAC_VER_06 ?
"ok" : "ko");
- if (r8168_check_dash(tp))
+ if (r8168_check_dash(tp)) {
+ netdev_info(dev, "DASH enabled\n");
rtl8168_driver_start(tp);
+ }
if (pci_dev_run_wake(pdev))
pm_runtime_put_sync(&pdev->dev);
--
2.27.0
next prev parent reply other threads:[~2020-06-17 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 20:50 [PATCH net-next 0/8] r8169: smaller improvements again Heiner Kallweit
2020-06-17 20:51 ` Heiner Kallweit [this message]
2020-06-17 20:51 ` [PATCH net-next 2/8] r8169: remove unused constant RsvdMask Heiner Kallweit
2020-06-17 20:52 ` [PATCH net-next 3/8] r8169: improve setting WoL on runtime-resume Heiner Kallweit
2020-06-17 20:53 ` [PATCH net-next 4/8] r8169: replace synchronize_rcu with synchronize_net Heiner Kallweit
2020-06-17 20:54 ` [PATCH net-next 5/8] r8169: move napi_disable call and rename rtl8169_hw_reset Heiner Kallweit
2020-06-17 20:54 ` [PATCH net-next 6/8] r8169: move updating counters to rtl8169_down Heiner Kallweit
2020-06-17 20:55 ` [PATCH net-next 7/8] r8169: move switching optional clock on/off to pll power functions Heiner Kallweit
2020-06-17 20:56 ` [PATCH net-next 8/8] r8169: allow setting irq coalescing if link is down Heiner Kallweit
2020-06-19 3:40 ` [PATCH net-next 0/8] r8169: smaller improvements again David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1385f3c-49d2-35f5-15d4-783cccf80ed5@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).