From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951C5C43381 for ; Mon, 1 Apr 2019 21:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50EC6206C0 for ; Mon, 1 Apr 2019 21:37:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bUKJ0EVJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725897AbfDAVhg (ORCPT ); Mon, 1 Apr 2019 17:37:36 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:41458 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfDAVhf (ORCPT ); Mon, 1 Apr 2019 17:37:35 -0400 Received: by mail-yw1-f66.google.com with SMTP id l15so3829678ywe.8 for ; Mon, 01 Apr 2019 14:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IiZHHHnKfChO2+t040zIw9f+N3yornzpplPzgYXzkYk=; b=bUKJ0EVJProfMexsCJ6tqvrIYvCc0RGCmVVY253rgEDCP+GKfJMJ/8KUnmHKsf3fox 5uO1R7goIw5kqPUXeUAfl9/Xi6iKDTPSqajNdrR+3eODja/1kTCgzICB2CFYWOuq62Rh Vry9SlVRKbEV0zyeDJxx5Jl7V4WtRlDyuQAWzv3v24G66mAC8iW2zIZ4k3rmXAlJvW3X 76LskrwTVY2e4jTg1ewUjuZbwVG1vwc5djaJXE3Gcejko5b26+sdER+s4kYe13BEe5N/ aqmAeUCx7ewIsJ7wSGNaBsy7f4DQ+tvHfAI6wx4vACMZMbyGKm4Mpe0l70DlxWglpiWJ CDKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IiZHHHnKfChO2+t040zIw9f+N3yornzpplPzgYXzkYk=; b=dURgfpvad32StDEzJtmSuB7XUxNtczPlgjjAP6IWml3AeKDRix4LSrwt9Z8H9qw5U+ VeDHlVcUe6ELcIsONPmSgNPp58ug9vPGcGrOwMahylqN5EMS/5LgPdyfVabiFRIIJagm FehSwXvLEUIyKbj7B+XBSmJ3y58YkZKA+a7UtUYuppLijYzee5Ruvbpei5ny6/eHRCDy yX+Z+gKYxlc+qlvAvSHC0fAzx/VwZzz4xJ6LQ3NmbibLQXOCmYKFEMMgwJtUMfGB51fK JokYmS6+XqCa5P8s04faycVKoudMG2Z3ZEshNA08l9KfAEBoQN6XU1lqIL1E2VJ6pXow WbZw== X-Gm-Message-State: APjAAAVJFmXL6aPyfJYPCGd2LxisV4S+u62nFhVAewkGMWTBRph4sC3j 6QjCn/CuS5/YiCp12pXXkhSafkKE X-Google-Smtp-Source: APXvYqzY3IFB91kKueR+6wqlK5SuPf8nrTKeaFN6C6YZrlKYak30ExPUESZKG8e649D7Ut/HnFJ86w== X-Received: by 2002:a0d:f8c2:: with SMTP id i185mr57165371ywf.362.1554154653832; Mon, 01 Apr 2019 14:37:33 -0700 (PDT) Received: from [10.67.49.126] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id c205sm3949835ywc.66.2019.04.01.14.37.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 14:37:32 -0700 (PDT) Subject: Re: [PATCH 1/2] net: enable IPv6 iff IPv4 To: =?UTF-8?Q?Maciej_=c5=bbenczykowski?= , =?UTF-8?Q?Maciej_=c5=bbenczykowski?= , "David S . Miller" Cc: netdev@vger.kernel.org References: <20190401194459.168345-1-zenczykowski@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Mon, 1 Apr 2019 14:37:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190401194459.168345-1-zenczykowski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/1/19 12:44 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > IPv6 is 20 years old and IPv4 has run out of IP addresses > and is deprecated. > > It is time to make IPv6 a first class citizen. > > As such we remove the ability to compile IPv6 as a module, > and IPv4 support now implies IPv6 support.> > This has the nice benefit of allowing upcoming code simplification: > all IPv6 module support can be removed, and we'll be able to merge > IPv6 socket state into the base IPv4 socket state... If you exclude size increase for the built-in part of the kernel, yes, it's all beneficial. There are tons of systems where IPv6 will likely never be used, let's face it, so why kill the ability to insmod the IPv6 stack since it really does not come at the cost of trying to fix the unloading part already? I am not convinced this is solving any problems TBH... > > At some point we should be able to reverse things and make IPv4 > the optional protocol and possibly even make an ipv4.ko. > > Signed-off-by: Maciej Żenczykowski > --- > net/Kconfig | 1 + > net/ipv6/Kconfig | 7 +------ > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/net/Kconfig b/net/Kconfig > index 3e8fdd688329..0f2ca2137f9e 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -68,6 +68,7 @@ config INET > bool "TCP/IP networking" > select CRYPTO > select CRYPTO_AES > + select IPV6 > ---help--- > These are the protocols used on the Internet and on most local > Ethernets. It is highly recommended to say Y here (this will enlarge > diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig > index 613282c65a10..9197f496a112 100644 > --- a/net/ipv6/Kconfig > +++ b/net/ipv6/Kconfig > @@ -2,10 +2,8 @@ > # IPv6 configuration > # > > -# IPv6 as module will cause a CRASH if you try to unload it > menuconfig IPV6 > - tristate "The IPv6 protocol" > - default y > + bool "The IPv6 protocol" Huh, no, please? If you need IPv6 make it built-in to your kernel, but don't bother people taht > ---help--- > Support for IP version 6 (IPv6). > > @@ -15,9 +13,6 @@ menuconfig IPV6 > Documentation/networking/ipv6.txt and read the HOWTO at > > > - To compile this protocol support as a module, choose M here: the > - module will be called ipv6. > - > if IPV6 > > config IPV6_ROUTER_PREF > -- Florian