From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation Date: Thu, 8 Nov 2018 12:13:53 -0800 Message-ID: References: <31ee2a24-103c-ac0a-9e60-b3204bd61167@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Edward Cree , linux-net-drivers@solarflare.com, davem@davemloft.net Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:40532 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbeKIFvA (ORCPT ); Fri, 9 Nov 2018 00:51:00 -0500 Received: by mail-pl1-f193.google.com with SMTP id q19-v6so7053323pll.7 for ; Thu, 08 Nov 2018 12:13:57 -0800 (PST) In-Reply-To: <31ee2a24-103c-ac0a-9e60-b3204bd61167@solarflare.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/08/2018 11:47 AM, Edward Cree wrote: > As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which > see for performance rationale. > > Signed-off-by: Edward Cree > --- > drivers/net/ethernet/sfc/tx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index c3ad564ac4c0..22eb059086f7 100644 > --- a/drivers/net/ethernet/sfc/tx.c > +++ b/drivers/net/ethernet/sfc/tx.c > @@ -553,13 +553,10 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb) > if (!data_mapped && (efx_tx_map_data(tx_queue, skb, segments))) > goto err; > > - /* Update BQL */ > - netdev_tx_sent_queue(tx_queue->core_txq, skb_len); > - > efx_tx_maybe_stop_queue(tx_queue); > > /* Pass off to hardware */ > - if (!xmit_more || netif_xmit_stopped(tx_queue->core_txq)) { > + if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more)) { > struct efx_tx_queue *txq2 = efx_tx_queue_partner(tx_queue); > > /* There could be packets left on the partner queue if those > Reviewed-by: Eric Dumazet Thanks !