From: Pkshih <pkshih@realtek.com>
To: Colin King <colin.king@canonical.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version
Date: Fri, 8 Oct 2021 09:33:26 +0000 [thread overview]
Message-ID: <e16b11a8d8f640d9be4ae2be21370d8a@realtek.com> (raw)
In-Reply-To: <20211007163722.20165-1-colin.king@canonical.com>
> -----Original Message-----
> From: Colin King <colin.king@canonical.com>
> Sent: Friday, October 8, 2021 12:37 AM
> To: Pkshih <pkshih@realtek.com>; Kalle Valo <kvalo@codeaurora.org>; David S . Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable version is being initialized with a value that is
> never read, it is being updated afterwards in both branches of
> an if statement. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> index 88fa2e593fef..76189283104c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c
> @@ -1430,7 +1430,7 @@ static enum version_8192e _rtl92ee_read_chip_version(struct ieee80211_hw
> *hw)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_phy *rtlphy = &rtlpriv->phy;
> - enum version_8192e version = VERSION_UNKNOWN;
> + enum version_8192e version;
> u32 value32;
>
> rtlphy->rf_type = RF_2T2R;
> --
> 2.32.0
>
> ------Please consider the environment before printing this e-mail.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2021-10-08 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 16:37 [PATCH] rtlwifi: rtl8192ee: Remove redundant initialization of variable version Colin King
2021-10-08 9:33 ` Pkshih [this message]
2021-10-13 6:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e16b11a8d8f640d9be4ae2be21370d8a@realtek.com \
--to=pkshih@realtek.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).