* [PATCH][next] ice: make const read-only array dflt_rules static
@ 2025-03-17 14:46 Colin Ian King
2025-03-17 15:23 ` Colin King (gmail)
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2025-03-17 14:46 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Simona Vetter, Tony Nguyen, Przemek Kitszel,
Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-gfx, dri-devel, intel-wired-lan, netdev
Cc: kernel-janitors, linux-kernel
Don't populate the const read-only array dflt_rules on the stack at run
time, instead make it static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/i915/intel_memory_region.c | 2 +-
drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
index d40ee1b42110..7f4102edc75b 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/intel_memory_region.c
@@ -62,7 +62,7 @@ static int iopagetest(struct intel_memory_region *mem,
resource_size_t offset,
const void *caller)
{
- const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
+ static const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
void __iomem *va;
int err;
int i;
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
index 1d118171de37..aceec184e89b 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
@@ -1605,7 +1605,7 @@ void ice_fdir_replay_fltrs(struct ice_pf *pf)
*/
int ice_fdir_create_dflt_rules(struct ice_pf *pf)
{
- const enum ice_fltr_ptype dflt_rules[] = {
+ static const enum ice_fltr_ptype dflt_rules[] = {
ICE_FLTR_PTYPE_NONF_IPV4_TCP, ICE_FLTR_PTYPE_NONF_IPV4_UDP,
ICE_FLTR_PTYPE_NONF_IPV6_TCP, ICE_FLTR_PTYPE_NONF_IPV6_UDP,
};
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] ice: make const read-only array dflt_rules static
2025-03-17 14:46 [PATCH][next] ice: make const read-only array dflt_rules static Colin Ian King
@ 2025-03-17 15:23 ` Colin King (gmail)
0 siblings, 0 replies; 2+ messages in thread
From: Colin King (gmail) @ 2025-03-17 15:23 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Simona Vetter, Tony Nguyen, Przemek Kitszel,
Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-gfx, dri-devel, intel-wired-lan, netdev
Cc: kernel-janitors, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1688 bytes --]
Ignore, managed to mangle two commits into one.
On 17/03/2025 14:46, Colin Ian King wrote:
> Don't populate the const read-only array dflt_rules on the stack at run
> time, instead make it static.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_memory_region.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
> index d40ee1b42110..7f4102edc75b 100644
> --- a/drivers/gpu/drm/i915/intel_memory_region.c
> +++ b/drivers/gpu/drm/i915/intel_memory_region.c
> @@ -62,7 +62,7 @@ static int iopagetest(struct intel_memory_region *mem,
> resource_size_t offset,
> const void *caller)
> {
> - const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
> + static const u8 val[] = { 0x0, 0xa5, 0xc3, 0xf0 };
> void __iomem *va;
> int err;
> int i;
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> index 1d118171de37..aceec184e89b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> @@ -1605,7 +1605,7 @@ void ice_fdir_replay_fltrs(struct ice_pf *pf)
> */
> int ice_fdir_create_dflt_rules(struct ice_pf *pf)
> {
> - const enum ice_fltr_ptype dflt_rules[] = {
> + static const enum ice_fltr_ptype dflt_rules[] = {
> ICE_FLTR_PTYPE_NONF_IPV4_TCP, ICE_FLTR_PTYPE_NONF_IPV4_UDP,
> ICE_FLTR_PTYPE_NONF_IPV6_TCP, ICE_FLTR_PTYPE_NONF_IPV6_UDP,
> };
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-17 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-17 14:46 [PATCH][next] ice: make const read-only array dflt_rules static Colin Ian King
2025-03-17 15:23 ` Colin King (gmail)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).