From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B935C43460 for ; Mon, 26 Apr 2021 02:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EAF861354 for ; Mon, 26 Apr 2021 02:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbhDZCcJ (ORCPT ); Sun, 25 Apr 2021 22:32:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbhDZCcI (ORCPT ); Sun, 25 Apr 2021 22:32:08 -0400 Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FF5EC061574 for ; Sun, 25 Apr 2021 19:31:27 -0700 (PDT) Received: by mail-oo1-xc2b.google.com with SMTP id e12-20020a056820060cb02901e94efc049dso7010111oow.9 for ; Sun, 25 Apr 2021 19:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IxAI/mgIy2q+f0V1oWqgPnnZYIM9N1YjbTvBrudlesk=; b=aDtSGSfdcpV6Bv03FpTCIpKuQpgpSiVetmqUWbBYKlqIAEW3BQOwhBo6rxJOWqxgqC zYFoi4g/OkLXYJmYS+c/s9XcKcF5z6ATb5YhKXXqduHNQsVHDBJcOPqPRG5+gZYKOONq Ml7qhTGIoZUgssDKEO4g1+bzgXK8VK3297dTfsh45yd2W91Ylu64ytRZtIEv4jAlWuO5 2jY6AbW9bwTlNmApxxwEV0FA3s7Fxda5jCynNbS6qKfEpEWPGfmp8RZbmfAJ7ZSwS2Sn 2BqCc6iVHs60z8lMpct/1iOiRoxtS85MtYUuA71TdOV0IPl+NB48b9r+joLt69Wy0CGz IJBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IxAI/mgIy2q+f0V1oWqgPnnZYIM9N1YjbTvBrudlesk=; b=OGdVXHLH5/4vXiLQrXcY6LGbTAMNSwhnbUWFqn6/nLcn3OTvGMmHo786xdbB9W053G cfWcYGl6sgyGbtqE3obMWYXUj0FQfdvQkslWapQODRKV3FajAJfMIFvr5OOmzS4T1l1L P221FA7vmNyaOwNUpqUTYwFB51KRkyydVst3CtsGLcp91v6pMDiWBNVzcvCPNps6QXLd hJ9tRYzounaRQhSKLZp2qOkGdidS+fKEH29vqMjfT7SqPiPgYYYun+6Er/kg2NL7k2DK UTTDf+bk99g3Q5XXaL3YuUQWMtXfvLDaaPy+uk4JEhO+eltMV2d20EEq2ME7HI51wKZY 1Pfw== X-Gm-Message-State: AOAM533TqXNAXhGcpAJhf8DmfMyguhrE/pkmxu93Jw4KrC76JXn/lp1z /pGPR/y1SJUStiltmnFrMfmo0w+Pp5A= X-Google-Smtp-Source: ABdhPJz8LNlE9F5HAsClp4VLxk+FgGE5DtkQukWtxQOP5BYtdnnpb6qcDHspo7kZ+S7jL0BkxB0Vew== X-Received: by 2002:a4a:855d:: with SMTP id l29mr11357931ooh.29.1619404286761; Sun, 25 Apr 2021 19:31:26 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.33]) by smtp.googlemail.com with ESMTPSA id b12sm3173913oti.17.2021.04.25.19.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Apr 2021 19:31:26 -0700 (PDT) Subject: Re: [PATCH iproute2 v2] ip: drop 2-char command assumption To: Tony Ambardar , Stephen Hemminger , David Ahern Cc: netdev@vger.kernel.org References: <9008a711-be95-caf7-5c56-dad5450e8f5c@gmail.com> <20210420082636.1210305-1-Tony.Ambardar@gmail.com> From: David Ahern Message-ID: Date: Sun, 25 Apr 2021 20:31:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210420082636.1210305-1-Tony.Ambardar@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/20/21 1:26 AM, Tony Ambardar wrote: > The 'ip' utility hardcodes the assumption of being a 2-char command, where > any follow-on characters are passed as an argument: > > $ ./ip-full help > Object "-full" is unknown, try "ip help". > > This confusing behaviour isn't seen with 'tc' for example, and was added in > a 2005 commit without documentation. It was noticed during testing of 'ip' > variants built/packaged with different feature sets (e.g. w/o BPF support). > > Mitigate the problem by redoing the command without the 2-char assumption > if the follow-on characters fail to parse as a valid command. > > Fixes: 351efcde4e62 ("Update header files to 2.6.14") > Signed-off-by: Tony Ambardar > --- > v2: (feedback from David Ahern) > * work around problem but remain compatible with 2-char assumption > > --- > ip/ip.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > Applied. Thanks,