From: David Ahern <dsahern@gmail.com>
To: Miguel Fadon Perlines <mfadon@teldat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] arp: fix arp_filter on l3slave devices
Date: Wed, 4 Apr 2018 11:11:46 -0600 [thread overview]
Message-ID: <e18ff801-15a5-a587-0342-cd3e06421a40@gmail.com> (raw)
In-Reply-To: <HE1PR07MB087563C78F897EABB6B8F326B6A40@HE1PR07MB0875.eurprd07.prod.outlook.com>
On 4/4/18 4:13 AM, Miguel Fadon Perlines wrote:
> arp_filter performs an ip_route_output search for arp source address and
>
> checks if output device is the same where the arp request was received,
>
> if it is not, the arp request is not answered.
>
>
>
> This route lookup is always done on main route table so l3slave devices
>
> never find the proper route and arp is not answered.
>
>
>
> Passing l3mdev_master_ifindex_rcu(dev) return value as oif fixes the
>
> lookup for l3slave devices while maintaining same behavior for non
>
> l3slave devices as this function returns 0 in that case.
>
>
>
> Signed-off-by: Miguel Fadon Perlines <mfadon@teldat.com>
>
> ---
Miguel: The change looks fine to me. Your mail showed up as html; it
needs to be sent as plain text only.
next parent reply other threads:[~2018-04-04 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HE1PR07MB087563C78F897EABB6B8F326B6A40@HE1PR07MB0875.eurprd07.prod.outlook.com>
2018-04-04 17:11 ` David Ahern [this message]
2018-04-05 8:25 [PATCH net] arp: fix arp_filter on l3slave devices Miguel Fadon Perlines
2018-04-05 14:40 ` David Ahern
2018-04-06 2:05 ` David Miller
2018-04-09 3:36 ` Sasha Levin
2018-04-09 14:41 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e18ff801-15a5-a587-0342-cd3e06421a40@gmail.com \
--to=dsahern@gmail.com \
--cc=mfadon@teldat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).