From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] arp: fix arp_filter on l3slave devices Date: Wed, 4 Apr 2018 11:11:46 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit To: Miguel Fadon Perlines , "netdev@vger.kernel.org" Return-path: Received: from mail-pl0-f52.google.com ([209.85.160.52]:39134 "EHLO mail-pl0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbeDDRLt (ORCPT ); Wed, 4 Apr 2018 13:11:49 -0400 Received: by mail-pl0-f52.google.com with SMTP id s24-v6so14930431plq.6 for ; Wed, 04 Apr 2018 10:11:49 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/4/18 4:13 AM, Miguel Fadon Perlines wrote: > arp_filter performs an ip_route_output search for arp source address and > > checks if output device is the same where the arp request was received, > > if it is not, the arp request is not answered. > >   > > This route lookup is always done on main route table so l3slave devices > > never find the proper route and arp is not answered. > >   > > Passing l3mdev_master_ifindex_rcu(dev) return value as oif fixes the > > lookup for l3slave devices while maintaining same behavior for non > > l3slave devices as this function returns 0 in that case. > >   > > Signed-off-by: Miguel Fadon Perlines > > --- Miguel: The change looks fine to me. Your mail showed up as html; it needs to be sent as plain text only.