From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net] bpf: enforce correct alignment for instructions Date: Wed, 20 Jun 2018 21:08:25 -0700 Message-ID: References: <20180621002409.63136-1-edumazet@google.com> <20180621.124639.2276956745930721354.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, daniel@iogearbox.net, kafai@fb.com, ast@kernel.org To: David Miller , edumazet@google.com Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:39143 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbeFUEI2 (ORCPT ); Thu, 21 Jun 2018 00:08:28 -0400 Received: by mail-pl0-f68.google.com with SMTP id s24-v6so916381plq.6 for ; Wed, 20 Jun 2018 21:08:28 -0700 (PDT) In-Reply-To: <20180621.124639.2276956745930721354.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/20/2018 08:46 PM, David Miller wrote: > From: Eric Dumazet > Date: Wed, 20 Jun 2018 17:24:09 -0700 > >> After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") >> offsetof(struct bpf_binary_header, image) became 3 instead of 4, >> breaking powerpc BPF badly, since instructions need to be word aligned. >> >> Fixes: 9facc336876f ("bpf: reject any prog that failed read-only lock") >> Signed-off-by: Eric Dumazet > > I'll apply this directly, thanks Eric. > Thanks David :)