From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4C2C43460 for ; Wed, 14 Apr 2021 06:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9484B6101B for ; Wed, 14 Apr 2021 06:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349379AbhDNGua (ORCPT ); Wed, 14 Apr 2021 02:50:30 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:45990 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239416AbhDNGu2 (ORCPT ); Wed, 14 Apr 2021 02:50:28 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13E6nopT097466; Wed, 14 Apr 2021 01:49:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618382990; bh=7cU4D04kdyILGRVSuThWUQaMOQqDRIEfWPmylp2Mimk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=TkCt8oYzhmi/2AzqPsmlu89Y6ETx+rlasl/2DF/qR5gVqRtBRRqfxzr7yg0EfBgZ3 U9cpaq+7Fw5W/zyrXLDLiBD2XDOLj9W06c+iTCCaQ+Jt3fQIFm4FH2W8i56bLn6iWC xixX7Pq56mhw5sksre/jPjqRSJ0nvlxduMR2qpwI= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13E6noWE035897 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 14 Apr 2021 01:49:50 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 14 Apr 2021 01:49:50 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 14 Apr 2021 01:49:50 -0500 Received: from [172.24.145.148] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13E6niiC127386; Wed, 14 Apr 2021 01:49:45 -0500 Subject: Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy To: Rob Herring CC: Vignesh Raghavendra , Kishon Vijay Abraham I , Lokesh Vutla , Grygorii Strashko , Faiz Abbas , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Vinod Koul , Sriram Dash , , , , , References: <20210409134056.18740-1-a-govindraju@ti.com> <20210409134056.18740-4-a-govindraju@ti.com> <20210412175134.GA4109207@robh.at.kernel.org> From: Aswath Govindraju Message-ID: Date: Wed, 14 Apr 2021 12:19:43 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210412175134.GA4109207@robh.at.kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Rob, On 12/04/21 11:21 pm, Rob Herring wrote: > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: >> From: Faiz Abbas >> >> Some transceivers need a configuration step (for example, pulling the >> standby or enable lines) for them to start sending messages. The >> transceiver can be implemented as a phy with the configuration done in the >> phy driver. The bit rate limitation can the be obtained by the driver using >> the phy node. >> >> Document the above implementation in the bosch mcan bindings >> >> Signed-off-by: Faiz Abbas >> Signed-off-by: Aswath Govindraju >> --- >> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> index 798fa5fb7bb2..2c01899b1a3e 100644 >> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> @@ -109,6 +109,12 @@ properties: >> can-transceiver: >> $ref: can-transceiver.yaml# >> >> + phys: >> + minItems: 1 > > maxItems: 1 Will add this in the respin. > >> + >> + phy-names: >> + const: can_transceiver > > Kind of a pointless name. You don't really need a name if there's a > single entry. > This name used by devm_phy_optional_get() in m_can driver to get the phy data structure. Thank you for the review. Regards, Aswath >> + >> required: >> - compatible >> - reg >> -- >> 2.17.1 >>