From: Ivan Vecera <ivecera@redhat.com>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Donald Hunter <donald.hunter@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Jonathan Corbet <corbet@lwn.net>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Michal Schmidt <mschmidt@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Pasi Vaananen <pvaanane@redhat.com>, Petr Oros <poros@redhat.com>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Simon Horman <horms@kernel.org>, Tariq Toukan <tariqt@nvidia.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] dpll: rework fractional frequency offset reporting
Date: Thu, 30 Apr 2026 16:58:44 +0200 [thread overview]
Message-ID: <e1e35bf4-19af-4d69-b310-993b3fef24a4@redhat.com> (raw)
In-Reply-To: <20260429150817.3059763-1-ivecera@redhat.com>
On 4/29/26 5:08 PM, Ivan Vecera wrote:
> Rework how the fractional frequency offset (FFO) is reported in
> the DPLL subsystem.
>
> The fractional-frequency-offset-ppt attribute is moved from the
> top-level pin attributes into the pin-parent-device nested attribute
> set. This makes it consistent with phase-offset (which is already
> per-parent) and clarifies that FFO PPT represents the frequency
> difference between a pin and its parent DPLL device.
>
> The two FFO contexts are distinguished in the ffo_get callback:
> dpll=NULL for the top-level RX vs TX symbol rate offset and a valid
> dpll pointer for the nested pin vs DPLL offset.
>
> Patch 1 restructures the DPLL subsystem netlink handling, updates
> the YAML spec and driver-api documentation, and adds NULL guards
> to mlx5 and zl3073x drivers.
>
> Patch 2 implements the nested FFO for zl3073x using the
> dpll_df_offset_x register with ref_ofst=1, providing 2^-48
> resolution. The old per-reference frequency measurement is removed
> as it was redundant with measured-frequency.
>
> Ivan Vecera (2):
> dpll: move fractional-frequency-offset-ppt under pin-parent-device
> dpll: zl3073x: report FFO as DPLL vs input reference offset
>
> Documentation/driver-api/dpll.rst | 16 +++++++
> Documentation/netlink/specs/dpll.yaml | 11 +++--
> drivers/dpll/dpll_netlink.c | 34 ++++++++++----
> drivers/dpll/dpll_nl.c | 1 +
> drivers/dpll/zl3073x/chan.c | 31 ++++++++++++-
> drivers/dpll/zl3073x/chan.h | 14 ++++++
> drivers/dpll/zl3073x/core.c | 45 -------------------
> drivers/dpll/zl3073x/dpll.c | 34 +++++++-------
> drivers/dpll/zl3073x/ref.h | 14 ------
> drivers/dpll/zl3073x/regs.h | 15 +++++++
> .../net/ethernet/mellanox/mlx5/core/dpll.c | 4 ++
> 11 files changed, 126 insertions(+), 93 deletions(-)
After merge of "dpll: add pin operational state" this needs to be rebased...
Will send v2.
I.
prev parent reply other threads:[~2026-04-30 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 15:08 [PATCH net-next 0/2] dpll: rework fractional frequency offset reporting Ivan Vecera
2026-04-29 15:08 ` [PATCH net-next 1/2] dpll: move fractional-frequency-offset-ppt under pin-parent-device Ivan Vecera
2026-04-29 15:08 ` [PATCH net-next 2/2] dpll: zl3073x: report FFO as DPLL vs input reference offset Ivan Vecera
2026-04-30 14:58 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1e35bf4-19af-4d69-b310-993b3fef24a4@redhat.com \
--to=ivecera@redhat.com \
--cc=Prathosh.Satish@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=pvaanane@redhat.com \
--cc=saeedm@nvidia.com \
--cc=skhan@linuxfoundation.org \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox