Netdev List
 help / color / mirror / Atom feed
From: Xuanqiang Luo <xuanqiang.luo@linux.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
	maxime.chevallier@bootlin.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, chleroy@kernel.org,
	linux-kernel@vger.kernel.org,
	Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Subject: Re: [PATCH net v3 1/5] net: phy: split phy_probe() error paths
Date: Thu, 20 Aug 2026 18:05:54 +0800	[thread overview]
Message-ID: <e1f3d995-3192-45e7-b084-1db89a53d1e6@linux.dev> (raw)
In-Reply-To: <f1fb446a-eb3f-40c7-baaa-62ae961cd28a@lunn.ch>


在 2026/8/19 21:35, Andrew Lunn 写道:
> On Wed, Aug 19, 2026 at 02:02:32PM +0800, Xuanqiang Luo wrote:
>> -out:
>> +out_unreg_led_triggers:
>> +	if (!phydev->is_on_sfp_module)
>> +		phy_led_triggers_unregister(phydev);
>> +
>> +out_sfp_release:
>>   	sfp_bus_del_upstream(phydev->sfp_bus);
>>   	phydev->sfp_bus = NULL;
>>   
>>   	phy_cleanup_ports(phydev);
>>   
>> -	if (!phydev->is_on_sfp_module)
>> -		phy_led_triggers_unregister(phydev);
>> -
> It would be nice to mention this reorder in the commit message. The
> commit message is about "Why?". Explain why the order has been
> changed.
> 	
>      Andrew

Sure, I'll explain it in more detail in the next revision.

Thanks,
Xuanqiang


  reply	other threads:[~2026-08-20 10:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  6:02 [PATCH net v3 0/5] net: phy: fix cleanup after probe failure Xuanqiang Luo
2026-08-19  6:02 ` [PATCH net v3 1/5] net: phy: split phy_probe() error paths Xuanqiang Luo
2026-08-19 13:35   ` Andrew Lunn
2026-08-20 10:05     ` Xuanqiang Luo [this message]
2026-08-19  6:02 ` [PATCH net v3 2/5] net: phy: unregister SFP upstream before port cleanup Xuanqiang Luo
2026-08-19 13:36   ` Andrew Lunn
2026-08-19  6:02 ` [PATCH net v3 3/5] net: phy: set PHY_READY after LED setup Xuanqiang Luo
2026-08-19 13:37   ` Andrew Lunn
2026-08-20 10:06   ` Xuanqiang Luo
2026-08-20 14:26     ` Andrew Lunn
2026-08-19  6:02 ` [PATCH net v3 4/5] net: phy: call driver remove when core initialization fails Xuanqiang Luo
2026-08-19 13:37   ` Andrew Lunn
2026-08-19  6:02 ` [PATCH net v3 5/5] net: phy: propagate errors from default port setup Xuanqiang Luo
2026-08-19  9:27   ` Maxime Chevallier
2026-08-19 13:33 ` [PATCH net v3 0/5] net: phy: fix cleanup after probe failure Andrew Lunn
2026-08-20 17:46   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1f3d995-3192-45e7-b084-1db89a53d1e6@linux.dev \
    --to=xuanqiang.luo@linux.dev \
    --cc=andrew@lunn.ch \
    --cc=chleroy@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luoxuanqiang@kylinos.cn \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox